mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-02-16 05:47:09 +08:00
chore: assign todos (#7297)
This commit is contained in:
@@ -147,7 +147,7 @@ export default {
|
||||
return;
|
||||
}
|
||||
|
||||
// TODO: right now we do not need the following
|
||||
// TODO(@Peng): right now we do not need the following
|
||||
// it is for octobase-node, but we dont use it for now.
|
||||
if (platform === 'darwin' && arch === 'arm64') {
|
||||
// In GitHub Actions runner, MacOS is always x64
|
||||
|
||||
@@ -26,7 +26,7 @@ function main() {
|
||||
performanceMainLogger.info('start');
|
||||
|
||||
// load persistent config for electron
|
||||
// TODO: should be sync, but it's not necessary for now
|
||||
// TODO(@Peng): should be sync, but it's not necessary for now
|
||||
appConfigProxy
|
||||
.getSync()
|
||||
.catch(() => console.error('failed to load app config'));
|
||||
|
||||
@@ -29,7 +29,7 @@ export const allHandlers = {
|
||||
};
|
||||
|
||||
export const registerHandlers = () => {
|
||||
// TODO: listen to namespace instead of individual event types
|
||||
// TODO(@Peng): listen to namespace instead of individual event types
|
||||
ipcMain.setMaxListeners(100);
|
||||
for (const [namespace, namespaceHandlers] of Object.entries(allHandlers)) {
|
||||
for (const [key, handler] of Object.entries(namespaceHandlers)) {
|
||||
|
||||
@@ -111,7 +111,7 @@ async function createWindow(additionalArguments: string[]) {
|
||||
});
|
||||
|
||||
browserWindow.on('close', e => {
|
||||
// TODO: gracefully close the app, for example, ask user to save unsaved changes
|
||||
// TODO(@Peng): gracefully close the app, for example, ask user to save unsaved changes
|
||||
e.preventDefault();
|
||||
if (!isMacOS()) {
|
||||
closeAllWindows();
|
||||
|
||||
@@ -79,7 +79,7 @@ async function createOnboardingWindow(additionalArguments: string[]) {
|
||||
// forcing zoom factor to 1 to avoid onboarding display issues
|
||||
browserWindow.webContents.setZoomFactor(1);
|
||||
fullscreenAndCenter(browserWindow);
|
||||
// TODO: add a timeout to avoid flickering, window is ready, but dom is not ready
|
||||
// TODO(@catsjuice): add a timeout to avoid flickering, window is ready, but dom is not ready
|
||||
setTimeout(() => {
|
||||
browserWindow.show();
|
||||
}, 300);
|
||||
|
||||
Reference in New Issue
Block a user