Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-14 13:25:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: assign todos (#7297)

Browse Source
This commit is contained in:
forehalo
2024-06-21 07:54:14 +00:00
parent e085b927f6
commit 7b3673ae82
121 changed files with 137 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/frontend/core/src/commands/affine-updates.tsx
View File

@@ -24,7 +24,7 @@ export function registerAffineUpdatesCommands({
preconditionStrategy: () => !!store.get(updateReadyAtom),
run() {
apis?.updater.quitAndInstall().catch(err => {
// TODO: add error toast here
// TODO(@JimmFly): add error toast here
console.error(err);
});
},

6
packages/frontend/core/src/commands/registry/command.ts
View File

@@ -1,6 +1,6 @@
import type { ReactNode } from 'react';
// TODO: need better way for composing different precondition strategies
// TODO(@Peng): need better way for composing different precondition strategies
export enum PreconditionStrategy {
Always,
InPaperOrEdgeless,
@@ -52,11 +52,11 @@ export interface AffineCommandOptions {
title: string;
subTitle?: string;
});
icon: ReactNode; // todo: need a mapping from string -> React element/SVG
icon: ReactNode; // TODO(@JimmFly): need a mapping from string -> React element/SVG
category?: CommandCategory;
// we use https://github.com/jamiebuilds/tinykeys so that we can use the same keybinding definition
// for both mac and windows
// todo: render keybinding in command palette
// TODO(@Peng): render keybinding in command palette
keyBinding?: KeybindingOptions | string;
run: () => void | Promise<void>;
}