Jayden/AFFiNE-Mirror
0
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-07-16 09:36:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): use nullable inline editor root element (#9320)

Browse Source 
Fixes `sentry-7906c03b79a54ede819c56cc15ad9889`
This commit is contained in:
doodlewind
2024-12-26 07:55:15 +00:00
parent cb4dd127fd
commit 71b5cddea1
16 changed files with 58 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
blocksuite/framework/inline/src/inline-editor.ts
+8 -7
View File
@@ -1,5 +1,5 @@
import { BlockSuiteError, ErrorCode } from '@blocksuite/global/exceptions';
import { assertExists, DisposableGroup, Slot } from '@blocksuite/global/utils';
import { DisposableGroup, Slot } from '@blocksuite/global/utils';
import { type Signal, signal } from '@preact/signals-core';
import { nothing, render, type TemplateResult } from 'lit';
import type * as Y from 'yjs';
@@ -136,7 +136,6 @@ export class InlineEditor<
private _rootElement: InlineRootElement<TextAttributes> | null = null;
get rootElement() {
assertExists(this._rootElement);
return this._rootElement;
}
@@ -244,7 +243,7 @@ export class InlineEditor<
this._rootElement.dataset.vRoot = 'true';
this.setReadonly(isReadonly);
this.rootElement.replaceChildren();
this._rootElement.replaceChildren();
delete (this.rootElement as any)['_$litPart$'];
@@ -259,10 +258,12 @@ export class InlineEditor<
}
unmount() {
if (this.rootElement.isConnected) {
render(nothing, this.rootElement);
if (this.rootElement) {
if (this.rootElement.isConnected) {
render(nothing, this.rootElement);
}
this.rootElement.removeAttribute(INLINE_ROOT_ATTR);
}
this.rootElement.removeAttribute(INLINE_ROOT_ATTR);
this._rootElement = null;
this._mounted = false;
this.disposables.dispose();
@@ -272,7 +273,7 @@ export class InlineEditor<
setReadonly(isReadonly: boolean): void {
const value = isReadonly ? 'false' : 'true';
if (this.rootElement.contentEditable !== value) {
if (this.rootElement && this.rootElement.contentEditable !== value) {
this.rootElement.contentEditable = value;
}