Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-25 18:26:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(storybook): storybook flaky (#5430)

Browse Source 
should add additional wait timeout for every story.play

I think this is a storybook issue. It seems that it starts to run the plays as soon as the following shows up:

![CleanShot 2023-12-28 at 17.32.49@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/33d5e49d-a2fd-46c5-9f31-0f7cc14c3acf.png)
This commit is contained in:
Peng Xiao
2023-12-28 10:07:05 +00:00
parent 9d51f9596f
commit 6fefe4ec71
1 changed files with 32 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
tests/storybook/src/stories/core.stories.tsx
View File

@@ -37,13 +37,18 @@ export const SettingPage: StoryFn = () => {
}; };
SettingPage.play = async ({ canvasElement, step }) => { SettingPage.play = async ({ canvasElement, step }) => {
const canvas = within(canvasElement); const canvas = within(canvasElement);
await waitFor(async () => { await waitFor(
assertExists( async () => {
document.body.querySelector( assertExists(
'[data-testid="slider-bar-workspace-setting-button"]' document.body.querySelector(
) '[data-testid="slider-bar-workspace-setting-button"]'
); )
}); );
},
{
timeout: 10000,
}
);
await step('click setting modal button', async () => { await step('click setting modal button', async () => {
await userEvent.click( await userEvent.click(
canvas.getByTestId('slider-bar-workspace-setting-button') canvas.getByTestId('slider-bar-workspace-setting-button')
@@ -121,13 +126,18 @@ export const SearchPage: StoryFn = () => {
}; };
SearchPage.play = async ({ canvasElement }) => { SearchPage.play = async ({ canvasElement }) => {
const canvas = within(canvasElement); const canvas = within(canvasElement);
await waitFor(async () => { await waitFor(
assertExists( async () => {
document.body.querySelector( assertExists(
'[data-testid="slider-bar-quick-search-button"]' document.body.querySelector(
) '[data-testid="slider-bar-quick-search-button"]'
); )
}); );
},
{
timeout: 3000,
}
);
await userEvent.click(canvas.getByTestId('slider-bar-quick-search-button')); await userEvent.click(canvas.getByTestId('slider-bar-quick-search-button'));
await waitFor( await waitFor(
() => { () => {
@@ -153,20 +163,20 @@ export const ImportPage: StoryFn = () => {
}; };
ImportPage.play = async ({ canvasElement }) => { ImportPage.play = async ({ canvasElement }) => {
const canvas = within(canvasElement); const canvas = within(canvasElement);
await waitFor(async () => {
assertExists(
document.body.querySelector('[data-testid="sidebar-new-page-button"]')
);
});
await userEvent.click(canvas.getByTestId('sidebar-new-page-button'));
await waitFor( await waitFor(
() => { async () => {
assertExists(canvasElement.querySelector('v-line')); assertExists(
document.body.querySelector('[data-testid="sidebar-new-page-button"]')
);
}, },
{ {
timeout: 10000, timeout: 10000,
} }
); );
await userEvent.click(canvas.getByTestId('sidebar-new-page-button'));
await waitFor(() => {
assertExists(canvasElement.querySelector('v-line'));
});
await waitFor(() => { await waitFor(() => {
assertExists( assertExists(
canvasElement.querySelector('[data-testid="header-dropDownButton"]') canvasElement.querySelector('[data-testid="header-dropDownButton"]')