Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-13 21:05:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(editor): reduce getService (#10100)

Browse Source
This commit is contained in:
Saul-Mirone
2025-02-11 12:26:01 +00:00
parent dbf0f9dc20
commit 6b78d2dcf2
33 changed files with 189 additions and 300 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
blocksuite/blocks/src/_specs/preset/mobile-patch.ts
View File

@@ -1,4 +1,5 @@
import type { CodeBlockConfig } from '@blocksuite/affine-block-code';
import { ParagraphBlockService } from '@blocksuite/affine-block-paragraph';
import {
type ReferenceNodeConfig,
ReferenceNodeConfigIdentifier,
@@ -100,7 +101,7 @@ export class MobileSpecsPatches extends LifeCycleWatcher {
override mounted() {
// remove slash placeholder for mobile: `type / ...`
{
const paragraphService = this.std.getService('affine:paragraph');
const paragraphService = this.std.get(ParagraphBlockService);
if (!paragraphService) return;
paragraphService.placeholderGenerator = model => {

9
blocksuite/blocks/src/root-block/edgeless/components/frame/frame-preview.ts
View File

@@ -5,6 +5,7 @@ import {
type EditorHost,
ShadowlessElement,
} from '@blocksuite/block-std';
import { GfxControllerIdentifier } from '@blocksuite/block-std/gfx';
import {
Bound,
debounce,
@@ -19,7 +20,6 @@ import { styleMap } from 'lit/directives/style-map.js';
import { SpecProvider } from '../../../../_specs/index.js';
import type { EdgelessRootPreviewBlockComponent } from '../../edgeless-root-preview-block.js';
import type { EdgelessRootService } from '../../edgeless-root-service.js';
const DEFAULT_PREVIEW_CONTAINER_WIDTH = 280;
const DEFAULT_PREVIEW_CONTAINER_HEIGHT = 166;
@@ -144,12 +144,9 @@ export class FramePreview extends WithDisposable(ShadowlessElement) {
if (!previewEditorHost) return;
const edgelessService = previewEditorHost.std.getService(
'affine:page'
) as EdgelessRootService;
const { viewport } = previewEditorHost.std.get(GfxControllerIdentifier);
const frameBound = Bound.deserialize(this.frame.xywh);
edgelessService.viewport.setViewportByBound(frameBound);
viewport.setViewportByBound(frameBound);
}
private _renderSurfaceContent() {

11
blocksuite/blocks/src/root-block/widgets/ai-panel/ai-panel.ts
View File

@@ -1,5 +1,6 @@
import type { AIError } from '@blocksuite/affine-components/ai-item';
import {
DocModeProvider,
NotificationProvider,
ThemeProvider,
} from '@blocksuite/affine-shared/services';
@@ -8,6 +9,7 @@ import {
stopPropagation,
} from '@blocksuite/affine-shared/utils';
import { WidgetComponent } from '@blocksuite/block-std';
import { GfxControllerIdentifier } from '@blocksuite/block-std/gfx';
import { assertExists } from '@blocksuite/global/utils';
import type { BaseSelection } from '@blocksuite/store';
import {
@@ -24,8 +26,6 @@ import { css, html, nothing, type PropertyValues } from 'lit';
import { property, query } from 'lit/decorators.js';
import { choose } from 'lit/directives/choose.js';
import type { EdgelessRootService } from '../../edgeless/edgeless-root-service.js';
import { PageRootService } from '../../page/page-root-service.js';
import { AFFINE_FORMAT_BAR_WIDGET } from '../format-bar/format-bar.js';
import {
AFFINE_VIEWPORT_OVERLAY_WIDGET,
@@ -363,12 +363,13 @@ export class AffineAIPanelWidget extends WidgetComponent {
): Partial<ComputePositionConfig> {
let rootBoundary: Rect | undefined;
{
const rootService = this.host.std.getService('affine:page');
if (rootService instanceof PageRootService) {
const docModeProvider = this.host.std.get(DocModeProvider);
if (docModeProvider.getEditorMode() === 'page') {
rootBoundary = undefined;
} else {
const gfx = this.host.std.get(GfxControllerIdentifier);
// TODO circular dependency: instanceof EdgelessRootService
const viewport = (rootService as EdgelessRootService).viewport;
const viewport = gfx.viewport;
rootBoundary = {
x: viewport.left,
y: viewport.top,