Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-13 12:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): fix upgrade popup (#11227)

Browse Source
This commit is contained in:
EYHN
2025-03-27 05:08:42 +00:00
parent bb1bbccd0f
commit 5f5c27fbdf
9 changed files with 48 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/frontend/core/src/modules/url/services/url.ts
View File

@@ -20,6 +20,8 @@ export class UrlService extends Service {
* open a popup window, provide different implementations in different environments.
* e.g. in electron, use system default browser to open a popup window.
*
* !IMPORTANT: browser will block popup windows in async callbacks, so you should use openExternal instead.
*
* @param url only full url with http/https protocol is supported
*/
openPopupWindow(url: string) {
@@ -28,4 +30,19 @@ export class UrlService extends Service {
}
this.popupWindowProvider?.open(url);
}
/**
* Opens an external URL with different implementations based on the environment.
* Unlike openPopupWindow, openExternal opens the URL in the current browser tab,
* making it more suitable for cases where popup windows might be blocked by browsers.
*
* @param url only full url with http/https protocol is supported
*/
openExternal(url: string) {
if (BUILD_CONFIG.isWeb || BUILD_CONFIG.isMobileWeb) {
location.href = url;
} else {
this.popupWindowProvider?.open(url);
}
}
}