fix: rewrite selection logic and frame selection handling logic (#12421)

Fixes [BS-3528](https://linear.app/affine-design/issue/BS-3528)
Fixes [BS-3331](https://linear.app/affine-design/issue/BS-3331/frame-移动逻辑很奇怪)

### Changed
- Remove `onSelected` method from gfx view, use `handleSelection` provided by `GfxViewInteraction` instead.
- Add `selectable` to allow model to filter out itself from selection.
- Frame can be selected by body only if it's locked or its background is not transparent.

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

- **New Features**
  - Enhanced selection behavior for frames, edgeless text, notes, and mind map elements with refined control based on lock state and background transparency.
  - Introduced group-aware selection logic promoting selection of appropriate group ancestors.
  - Added support for element selection events in interactivity extensions.

- **Bug Fixes**
  - Resolved frame selection issues by enabling selection via title clicks and restricting body selection to locked frames or those with non-transparent backgrounds.

- **Documentation**
  - Added clarifying comments for group retrieval methods.

- **Tests**
  - Updated and added end-to-end tests for frame and lock selection reflecting new selection conditions.

- **Refactor**
  - Unified and simplified selection handling by moving logic from component methods to interaction handlers and removing deprecated selection methods.
  - Streamlined selection candidate processing with extension-driven target suggestion.
  - Removed legacy group element retrieval and selection helper methods to simplify interaction logic.

- **Style**
  - Renamed types and improved type signatures for selection context and interaction configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
doouding
2025-05-26 05:03:08 +00:00
parent 14a89c1e8a
commit 5de63c29f5
21 changed files with 535 additions and 369 deletions
+1 -52
View File
@@ -26,10 +26,7 @@ import { LayerManager } from './layer.js';
import type { PointTestOptions } from './model/base.js';
import { GfxBlockElementModel } from './model/gfx-block-model.js';
import type { GfxModel } from './model/model.js';
import {
GfxGroupLikeElementModel,
GfxPrimitiveElementModel,
} from './model/surface/element-model.js';
import { GfxPrimitiveElementModel } from './model/surface/element-model.js';
import type { SurfaceBlockModel } from './model/surface/surface-model.js';
import { FIT_TO_SCREEN_PADDING, Viewport, ZOOM_INITIAL } from './viewport.js';
@@ -181,54 +178,6 @@ export class GfxController extends LifeCycleWatcher {
return last(picked) ?? null;
}
/**
* Get the top element in the given point.
* If the element is in a group, the group will be returned.
* If the group is currently selected, the child element will be returned.
* @param x
* @param y
* @param options
* @returns
*/
getElementInGroup(
x: number,
y: number,
options?: PointTestOptions
): GfxModel | null {
const selectionManager = this.selection;
const results = this.getElementByPoint(x, y, {
...options,
all: true,
});
let picked = last(results) ?? null;
const { activeGroup } = selectionManager;
const first = picked;
if (activeGroup && picked && activeGroup.hasDescendant(picked)) {
let index = results.length - 1;
while (
picked === activeGroup ||
(picked instanceof GfxGroupLikeElementModel &&
picked.hasDescendant(activeGroup))
) {
picked = results[--index];
}
} else if (picked) {
let index = results.length - 1;
while (picked.group instanceof GfxGroupLikeElementModel) {
if (--index < 0) {
picked = null;
break;
}
picked = results[index];
}
}
return (picked ?? first) as GfxModel | null;
}
/**
* Query all elements in an area.
* @param bound