fix: effect deps (#1940)

This commit is contained in:
Himself65
2023-04-14 00:24:44 -05:00
committed by GitHub
parent d58f9db289
commit 5ca94db5d2
11 changed files with 22 additions and 15 deletions

View File

@@ -43,6 +43,6 @@ export function useBlockSuiteWorkspaceAvatarUrl(
dispose.dispose();
};
}
}, []);
}, [blockSuiteWorkspace]);
return [avatar ?? null, setAvatar] as const;
}

View File

@@ -13,12 +13,15 @@ export function useBlockSuiteWorkspacePageIsPublic(page: Page) {
page.workspace.meta.pageMetasUpdated.on(() => {
set(page.meta.isPublic ?? false);
});
}, []);
const setIsPublic = useCallback((isPublic: boolean) => {
set(isPublic);
page.workspace.setPageMeta(page.id, {
isPublic,
});
}, []);
}, [page]);
const setIsPublic = useCallback(
(isPublic: boolean) => {
set(isPublic);
page.workspace.setPageMeta(page.id, {
isPublic,
});
},
[page.id, page.workspace]
);
return [isPublic, setIsPublic] as const;
}