fix: effect deps (#1940)

This commit is contained in:
Himself65
2023-04-14 00:24:44 -05:00
committed by GitHub
parent d58f9db289
commit 5ca94db5d2
11 changed files with 22 additions and 15 deletions

View File

@@ -50,7 +50,7 @@ const BlockSuiteEditorImpl = (props: EditorProps): ReactElement => {
}
props.onLoad?.(page, editor);
}
}, [props.page, props.onInit, props.onLoad]);
}, [props.page, props.onInit, props.onLoad, editor, props, page]);
const ref = useRef<HTMLDivElement>(null);

View File

@@ -53,10 +53,10 @@ export const AffineSharePage: FC<ShareMenuProps> = props => {
}, [props.workspace.id, props.currentPage.id]);
const onClickCreateLink = useCallback(() => {
setIsPublic(true);
}, [isPublic]);
}, [setIsPublic]);
const onClickCopyLink = useCallback(() => {
navigator.clipboard.writeText(sharingUrl);
}, []);
}, [sharingUrl]);
return (
<div className={menuItemStyle}>

View File

@@ -32,7 +32,7 @@ export const PublicLinkDisableModal = ({
portal: document.body,
});
onClose();
}, []);
}, [onClose, setIsPublic]);
return (
<Modal open={open} onClose={onClose}>
<StyledModalWrapper>

View File

@@ -78,7 +78,7 @@ const TreeNodeItemWithDnd = <RenderProps,>({
if (isOver && canDrop) {
setCollapsed(node.id, false);
}
}, [isOver, canDrop]);
}, [isOver, canDrop, setCollapsed, node.id]);
return (
<TreeNodeItem

View File

@@ -60,7 +60,7 @@ export const TreeView = <RenderProps,>({
document.removeEventListener('keydown', handleDirectionKeyDown);
document.removeEventListener('keydown', handleEnterKeyDown);
};
}, [data, selectedId]);
}, [data, enableKeyboardSelection, onSelect, selectedId]);
const setCollapsed: TreeNodeProps['setCollapsed'] = (id, collapsed) => {
if (disableCollapse) {