Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-13 21:05:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): missing signal of optional flat props (#13762)

Browse Source 
Close https://github.com/toeverything/AFFiNE/issues/13750

#### PR Dependency Tree


* **PR #13762** 👈

This tree was auto-generated by
[Charcoal](https://github.com/danerwilliams/charcoal)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Optional block properties are now supported (e.g., flat-table), with
default values applied automatically when not set.

* **Bug Fixes**
* More reliable initialization and syncing of block properties, ensuring
defaults appear consistently.
* Change notifications now correctly reflect updates to
optional/defaulted properties.

* **Tests**
* Added tests verifying optional property behavior, default application,
syncing, and change events.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->





#### PR Dependency Tree


* **PR #13762** 👈

This tree was auto-generated by
[Charcoal](https://github.com/danerwilliams/charcoal)
This commit is contained in:
L-Sun
2025-10-16 12:38:47 +08:00
committed by GitHub
parent e4f9d42990
commit 5c0e3b8a7f
3 changed files with 36 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
blocksuite/framework/store/src/reactive/flat-native-y/index.ts
View File

@@ -99,7 +99,8 @@ export class ReactiveFlatYMap extends BaseReactiveYData<
constructor(
protected readonly _ySource: YMap<unknown>,
private readonly _onDispose: Subject<void>,
private readonly _onChange?: OnChange
private readonly _onChange?: OnChange,
defaultProps?: Record<string, unknown>
) {
super();
this._initialized = false;
@@ -112,7 +113,7 @@ export class ReactiveFlatYMap extends BaseReactiveYData<
const proxy = this._getProxy(source, source);
Object.entries(source).forEach(([key, value]) => {
const initSignals = (key: string, value: unknown) => {
const signalData = signal(value);
source[`${key}$`] = signalData;
const unsubscribe = signalData.subscribe(next => {
@@ -128,11 +129,30 @@ export class ReactiveFlatYMap extends BaseReactiveYData<
subscription.unsubscribe();
unsubscribe();
});
};
Object.entries(source).forEach(([key, value]) => {
initSignals(key, value);
});
if (defaultProps) {
Object.entries(defaultProps).forEach(([key, value]) => {
if (!(key in proxy) && value === undefined) {
initSignals(key, value);
}
});
}
this._proxy = proxy;
this._ySource.observe(this._observer);
this._initialized = true;
if (defaultProps) {
Object.entries(defaultProps).forEach(([key, value]) => {
if (key in proxy || value === undefined) return;
proxy[key] = value;
});
}
}
pop = (prop: string): void => {