style: add no-misused-promises rule (#3547)

Co-authored-by: Peng Xiao <pengxiao@outlook.com>

.eslintrc.js

@@ -214,6 +214,7 @@ const config = {
             ignoreIIFE: false,
           },
         ],
+        '@typescript-eslint/no-misused-promises': ['error'],
       },
     })),
     {
@@ -239,6 +240,7 @@ const config = {
           },
         ],
         '@typescript-eslint/no-floating-promises': 0,
+        '@typescript-eslint/no-misused-promises': 0,
       },
     },
   ],

apps/electron/src/helper/db/ensure-db.ts

@@ -115,7 +115,11 @@ function startPollingSecondaryDB(db: WorkspaceSQLiteDB) {
       const secondaryDB = new SecondaryWorkspaceSQLiteDB(path, db);
       return new Observable<SecondaryWorkspaceSQLiteDB>(subscriber => {
         subscriber.next(secondaryDB);
-        return () => secondaryDB.destroy();
+        return () => {
+          secondaryDB.destroy().catch(err => {
+            subscriber.error(err);
+          });
+        };
       });
     }),
     switchMap(secondaryDB => {

apps/electron/src/main/index.ts

@@ -38,7 +38,7 @@ app.on('second-instance', () => {
   );
 });
 
-app.on('open-url', async (_, _url) => {
+app.on('open-url', (_, _url) => {
   // todo: handle `affine://...` urls
 });
 
@@ -54,7 +54,11 @@ app.on('window-all-closed', () => {
 /**
  * @see https://www.electronjs.org/docs/v14-x-y/api/app#event-activate-macos Event: 'activate'
  */
-app.on('activate', restoreOrCreateWindow);
+app.on('activate', () => {
+  restoreOrCreateWindow().catch(err => {
+    console.error(err);
+  });
+});
 
 /**
  * Create app window when background process will be ready

apps/electron/src/main/ui/google-auth.ts

@@ -34,7 +34,7 @@ export function getGoogleOauthCode() {
         logger.error('Failed to open external url', e);
         reject(e);
       });
-      const handleOpenUrl = async (_: any, url: string) => {
+      const handleOpenUrl = (_: any, url: string) => {
         const mainWindow = BrowserWindow.getAllWindows().find(
           w => !w.isDestroyed()
         );

apps/electron/src/main/updater/electron-updater.ts

@@ -99,7 +99,9 @@ export const registerUpdater = async () => {
   });
   autoUpdater.forceDevUpdateConfig = isDev;
 
-  app.on('activate', async () => {
+  app.on('activate', () => {
-    await checkForUpdates(false);
+    checkForUpdates(false).catch(err => {
+      console.error(err);
+    });
   });
 };

apps/electron/src/worker/plugin.ts

@@ -19,10 +19,15 @@ const mainThread = AsyncCall<{
   channel: new MessageEventChannel(parentPort),
 });
 
+// eslint-disable-next-line @typescript-eslint/no-misused-promises
 globalThis.console.log = mainThread.log;
+// eslint-disable-next-line @typescript-eslint/no-misused-promises
 globalThis.console.error = mainThread.log;
+// eslint-disable-next-line @typescript-eslint/no-misused-promises
 globalThis.console.info = mainThread.log;
+// eslint-disable-next-line @typescript-eslint/no-misused-promises
 globalThis.console.debug = mainThread.log;
+// eslint-disable-next-line @typescript-eslint/no-misused-promises
 globalThis.console.warn = mainThread.log;
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires

apps/server/src/modules/workspaces/resolver.ts

@@ -77,7 +77,7 @@ export class WorkspaceResolver {
       return workspace.permission;
     }
 
-    const permission = this.permissionProvider.get(workspace.id, user.id);
+    const permission = await this.permissionProvider.get(workspace.id, user.id);
 
     if (!permission) {
       throw new ForbiddenException();

apps/server/src/prisma/service.ts

@@ -9,8 +9,10 @@ export class PrismaService extends PrismaClient implements OnModuleInit {
   }
 
   async enableShutdownHooks(app: INestApplication) {
-    process.on('beforeExit', async () => {
+    process.on('beforeExit', () => {
-      await app.close();
+      app.close().catch(e => {
+        console.error(e);
+      });
     });
   }
 }

packages/component/src/components/notification-center/index.tsx

@@ -181,7 +181,9 @@ function NotificationCard(props: NotificationCardProps): ReactElement {
 
   const onClickUndo = useCallback(() => {
     if (notification.undo) {
-      return notification.undo();
+      notification.undo().catch(err => {
+        console.error(err);
+      });
     }
     return void 0;
   }, [notification]);

packages/component/src/components/page-list/view/collection-bar.tsx

@@ -63,10 +63,14 @@ export const CollectionBar = (props: CollectionBarProps) => {
           : t['com.affine.collection-bar.action.tooltip.pin'](),
         className: styles.pin,
         click: () => {
-          return setting.updateCollection({
+          setting
-            ...collection,
+            .updateCollection({
-            pinned: !collection.pinned,
+              ...collection,
-          });
+              pinned: !collection.pinned,
+            })
+            .catch(err => {
+              console.error(err);
+            });
         },
       },
       {
@@ -102,6 +106,7 @@ export const CollectionBar = (props: CollectionBarProps) => {
             init={collection}
             open={open}
             onClose={onClose}
+            // eslint-disable-next-line @typescript-eslint/no-misused-promises
             onConfirm={setting.updateCollection}
           ></EditCollectionModel>
           <ViewLayersIcon

packages/component/src/components/page-list/view/collection-list.tsx

@@ -43,10 +43,14 @@ const CollectionOption = ({
         icon: <PinIcon />,
         name: 'pin',
         click: () => {
-          return setting.updateCollection({
+          setting
-            ...collection,
+            .updateCollection({
-            pinned: !collection.pinned,
+              ...collection,
-          });
+              pinned: !collection.pinned,
+            })
+            .catch(err => {
+              console.error(err);
+            });
         },
       },
       {
@@ -144,10 +148,14 @@ export const CollectionList = ({
   const [collection, setCollection] = useState<Collection>();
   const onChange = useCallback(
     (filterList: Filter[]) => {
-      return setting.updateCollection({
+      setting
-        ...setting.currentCollection,
+        .updateCollection({
-        filterList,
+          ...setting.currentCollection,
-      });
+          filterList,
+        })
+        .catch(err => {
+          console.error(err);
+        });
     },
     [setting]
   );
@@ -156,10 +164,9 @@ export const CollectionList = ({
     []
   );
   const onConfirm = useCallback(
-    (view: Collection) => {
+    async (view: Collection) => {
-      return setting.updateCollection(view).then(() => {
+      await setting.updateCollection(view);
-        closeUpdateCollectionModal();
+      closeUpdateCollectionModal();
-      });
     },
     [closeUpdateCollectionModal, setting]
   );

packages/component/src/components/page-list/view/create-collection.tsx

@@ -32,7 +32,7 @@ type CreateCollectionProps = {
 };
 
 type SaveCollectionButtonProps = {
-  onConfirm: (collection: Collection) => void;
+  onConfirm: (collection: Collection) => Promise<void>;
   getPageInfo: GetPageInfoById;
   propertiesMeta: PropertiesMeta;
   filterList: Filter[];
@@ -49,7 +49,7 @@ export const EditCollectionModel = ({
   title,
 }: {
   init?: Collection;
-  onConfirm: (view: Collection) => void;
+  onConfirm: (view: Collection) => Promise<void>;
   open: boolean;
   onClose: () => void;
   title?: string;
@@ -57,6 +57,18 @@ export const EditCollectionModel = ({
   propertiesMeta: PropertiesMeta;
 }) => {
   const t = useAFFiNEI18N();
+  const onConfirmOnCollection = useCallback(
+    (view: Collection) => {
+      onConfirm(view)
+        .then(() => {
+          onClose();
+        })
+        .catch(err => {
+          console.error(err);
+        });
+    },
+    [onClose, onConfirm]
+  );
   return (
     <Modal open={open} onClose={onClose}>
       <ModalWrapper
@@ -75,10 +87,7 @@ export const EditCollectionModel = ({
             init={init}
             getPageInfo={getPageInfo}
             onCancel={onClose}
-            onConfirm={view => {
+            onConfirm={onConfirmOnCollection}
-              onConfirm(view);
-              onClose();
-            }}
           />
         ) : null}
       </ModalWrapper>

packages/component/src/components/share-menu/share-page.tsx

@@ -47,9 +47,15 @@ export const AffineSharePage: FC<ShareMenuProps> = props => {
   const onClickCreateLink = useCallback(() => {
     setIsPublic(true);
   }, [setIsPublic]);
-  const onClickCopyLink = useCallback(async () => {
+  const onClickCopyLink = useCallback(() => {
-    await navigator.clipboard.writeText(sharingUrl);
+    navigator.clipboard
-    toast(t['Copied link to clipboard']());
+      .writeText(sharingUrl)
+      .then(() => {
+        toast(t['Copied link to clipboard']());
+      })
+      .catch(err => {
+        console.error(err);
+      });
   }, [sharingUrl, t]);
   const onDisablePublic = useCallback(() => {
     setIsPublic(false);

packages/component/src/ui/toast/toast.ts

@@ -115,21 +115,26 @@ export const toast = (
 
   element.animate(fadeIn, options);
 
-  setTimeout(async () => {
+  setTimeout(() => {
     const animation = element.animate(
       // fade out
       fadeIn.reverse(),
       options
     );
-    await animation.finished;
+    animation.finished
-    element.style.maxHeight = '0';
+      .then(() => {
-    element.style.margin = '0';
+        element.style.maxHeight = '0';
-    element.style.padding = '0';
+        element.style.margin = '0';
-    // wait for transition
+        element.style.padding = '0';
-    // ToastContainer = null;
+        // wait for transition
-    element.addEventListener('transitionend', () => {
+        // ToastContainer = null;
-      element.remove();
+        element.addEventListener('transitionend', () => {
-    });
+          element.remove();
+        });
+      })
+      .catch(err => {
+        console.error(err);
+      });
   }, duration);
   return element;
 };

packages/i18n/src/scripts/download.ts

@@ -87,23 +87,22 @@ const main = async () => {
     language => language.completeRate > 0.4
   );
 
-  availableLanguages
+  for (const language of availableLanguages
     // skip base language
-    .filter(i => !i.base)
+    .filter(i => !i.base)) {
-    .forEach(async language => {
+    await fs.writeFile(
-      await fs.writeFile(
+      path.resolve(RES_DIR, `${language.tag}.json`),
-        path.resolve(RES_DIR, `${language.tag}.json`),
+      JSON.stringify(
-        JSON.stringify(
+        {
-          {
+          '// THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.':
-            '// THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.':
+            '',
-              '',
+          ...flattenTranslation(language.translations),
-            ...flattenTranslation(language.translations),
+        },
-          },
+        null,
-          null,
+        INDENT
-          INDENT
+      ) + '\n'
-        ) + '\n'
+    );
-      );
+  }
-    });
 
   console.log('Generating meta data...');
   const code = `// THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

packages/i18n/src/scripts/sync.ts

@@ -127,11 +127,11 @@ const main = async () => {
     return;
   }
 
-  diff.add.forEach(async key => {
+  for (const key of diff.add) {
     const val = flatLocalTranslations[key];
     console.log(`Creating new key: ${key} -> ${val}`);
     await createsNewKey(key, { [BASE_LANGUAGES]: val });
-  });
+  }
 
   // TODO remove unused tags from used keys
 

packages/infra/src/preload/electron.ts

@@ -116,7 +116,7 @@ function getMainAPIs() {
 }
 
 const helperPort$ = new Promise<MessagePort>(resolve =>
-  ipcRenderer.on('helper-connection', async e => {
+  ipcRenderer.on('helper-connection', e => {
     console.info('[preload] helper-connection', e);
     resolve(e.ports[0]);
   })

packages/workspace/src/providers/sqlite-providers.ts

@@ -106,14 +106,15 @@ export const createSQLiteDBDownloadProvider: DocProviderCreator = (
     cleanup: () => {
       // todo
     },
-    sync: async () => {
+    sync: () => {
       logger.info('connect sqlite download provider', id);
-      try {
+      syncUpdates(rootDoc)
-        await syncUpdates(rootDoc);
+        .then(() => {
-        _resolve();
+          _resolve();
-      } catch (error) {
+        })
-        _reject(error);
+        .catch(error => {
-      }
+          _reject(error);
+        });
     },
   };
 };

plugins/copilot/src/UI/detail-content.tsx

@@ -34,9 +34,12 @@ const Actions = () => {
         />
         <IconButton
           className={sendButtonStyle}
-          onClick={useCallback(async () => {
+          onClick={useCallback(() => {
-            await call(input);
+            call(input)
-            await generateFollowingUp();
+              .then(() => generateFollowingUp())
+              .catch(e => {
+                console.error(e);
+              });
           }, [call, generateFollowingUp, input])}
         >
           <SendIcon />