refactor: remove unused surface service (#11339)

blocksuite/affine/blocks/block-surface/src/commands/reassociate-connectors.ts

@@ -1,6 +1,7 @@
 import type { Command } from '@blocksuite/std';
+import { GfxControllerIdentifier } from '@blocksuite/std/gfx';
 
-import { SurfaceBlockService } from '../surface-service';
+import type { SurfaceBlockModel } from '../surface-model';
 
 /**
  * Re-associate bindings for block that have been converted.
@@ -13,14 +14,14 @@ export const reassociateConnectorsCommand: Command<{
   newId: string;
 }> = (ctx, next) => {
   const { oldId, newId } = ctx;
-  const service = ctx.std.get(SurfaceBlockService);
+  const gfx = ctx.std.get(GfxControllerIdentifier);
-  if (!oldId || !newId || !service) {
+  if (!oldId || !newId || !gfx.surface) {
     next();
     return;
   }
 
-  const surface = service.surface;
+  const surface = gfx.surface;
-  const connectors = surface.getConnectors(oldId);
+  const connectors = (surface as SurfaceBlockModel).getConnectors(oldId);
   for (const { id, source, target } of connectors) {
     if (source.id === oldId) {
       surface.updateElement(id, {

blocksuite/affine/blocks/block-surface/src/index.ts

@@ -56,7 +56,6 @@ export {
   SurfaceBlockSchema,
   SurfaceBlockSchemaExtension,
 } from './surface-model.js';
-export type { SurfaceBlockService } from './surface-service.js';
 export {
   EdgelessSurfaceBlockSpec,
   PageSurfaceBlockSpec,

blocksuite/affine/blocks/block-surface/src/surface-block-void.ts

@@ -2,12 +2,8 @@ import { BlockComponent } from '@blocksuite/std';
 import { nothing } from 'lit';
 
 import type { SurfaceBlockModel } from './surface-model.js';
-import type { SurfaceBlockService } from './surface-service.js';
 
-export class SurfaceBlockVoidComponent extends BlockComponent<
+export class SurfaceBlockVoidComponent extends BlockComponent<SurfaceBlockModel> {
-  SurfaceBlockModel,
-  SurfaceBlockService
-> {
   override render() {
     return nothing;
   }

blocksuite/affine/blocks/block-surface/src/surface-block.ts

@@ -17,7 +17,6 @@ import {
 } from './renderer/elements/index.js';
 import { OverlayIdentifier } from './renderer/overlay.js';
 import type { SurfaceBlockModel } from './surface-model.js';
-import type { SurfaceBlockService } from './surface-service.js';
 
 export interface SurfaceContext {
   viewport: Viewport;
@@ -31,10 +30,7 @@ export interface SurfaceContext {
   };
 }
 
-export class SurfaceBlockComponent extends BlockComponent<
+export class SurfaceBlockComponent extends BlockComponent<SurfaceBlockModel> {
-  SurfaceBlockModel,
-  SurfaceBlockService
-> {
   static isConnector = (element: unknown): element is ConnectorElementModel => {
     return element instanceof ConnectorElementModel;
   };

blocksuite/affine/blocks/block-surface/src/surface-service.ts

@@ -1,37 +0,0 @@
-import { BlockService } from '@blocksuite/std';
-import { GfxControllerIdentifier } from '@blocksuite/std/gfx';
-
-import { type SurfaceBlockModel, SurfaceBlockSchema } from './surface-model.js';
-import { getSurfaceBlock } from './utils/get-surface-block.js';
-
-export class SurfaceBlockService extends BlockService {
-  static override readonly flavour = SurfaceBlockSchema.model.flavour;
-
-  surface!: SurfaceBlockModel;
-
-  get layer() {
-    return this.std.get(GfxControllerIdentifier).layer;
-  }
-
-  override mounted(): void {
-    super.mounted();
-
-    const surface = getSurfaceBlock(this.doc);
-
-    // FIXME: BS-2271
-    this.surface = surface!;
-
-    if (!this.surface) {
-      const disposable = this.doc.slots.blockUpdated.subscribe(payload => {
-        if (payload.flavour === 'affine:surface') {
-          disposable.unsubscribe();
-          const surface = this.doc.getModelById(
-            payload.id
-          ) as SurfaceBlockModel | null;
-          if (!surface) return;
-          this.surface = surface;
-        }
-      });
-    }
-  }
-}

blocksuite/affine/blocks/block-surface/src/surface-spec.ts

@@ -11,11 +11,9 @@ import {
   EdgelessLegacySlotExtension,
 } from './extensions';
 import { ExportManagerExtension } from './extensions/export-manager/export-manager';
-import { SurfaceBlockService } from './surface-service';
 
 const CommonSurfaceBlockSpec: ExtensionType[] = [
   FlavourExtension('affine:surface'),
-  SurfaceBlockService,
   EdgelessCRUDExtension,
   EdgelessLegacySlotExtension,
   ExportManagerExtension,