Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-18 23:07:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: retrieve lost cursor after closing search (#899)

Browse Source
This commit is contained in:
JimmFly
2023-02-09 06:05:15 +08:00
committed by GitHub
parent 7583205011
commit 53d60a13b2
3 changed files with 76 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
tests/quick-search.spec.ts
View File

@@ -8,24 +8,20 @@ loadPage();
const openQuickSearchByShortcut = async (page: Page) =>
await withCtrlOrMeta(page, () => page.keyboard.press('k', { delay: 50 }));
async function assertTitleTexts(page: Page, texts: string, isSearch?: boolean) {
if (isSearch) {
const actual = await page.evaluate(() => {
const titleElement = <HTMLTextAreaElement>(
document.querySelector('.affine-default-page-block-title')
);
return titleElement.value;
});
expect(actual).toEqual(texts);
} else {
const actual = await page.title();
expect(actual).toEqual(texts);
}
async function assertTitle(page: Page, text: string) {
const locator = page.locator('.affine-default-page-block-title').nth(0);
const actual = await locator.inputValue();
expect(actual).toBe(text);
}
async function assertResultList(page: Page, texts: string[]) {
const actual = await page.locator('[cmdk-item]').allInnerTexts();
expect(actual).toEqual(texts);
}
async function titleIsFocused(page: Page) {
const title = page.locator('.affine-default-page-block-title');
await expect(title).toBeVisible();
await expect(title).toBeFocused();
}
test.describe('Open quick search', () => {
test('Click slider bar button', async ({ page }) => {
@@ -63,7 +59,7 @@ test.describe('Add new page in quick search', () => {
const addNewPage = page.locator('[data-testid=quickSearch-addNewPage]');
await addNewPage.click();
await page.waitForTimeout(300);
await assertTitleTexts(page, 'Untitled');
await assertTitle(page, '');
});
test('Create a new page with keyword', async ({ page }) => {
@@ -73,11 +69,18 @@ test.describe('Add new page in quick search', () => {
const addNewPage = page.locator('[data-testid=quickSearch-addNewPage]');
await addNewPage.click();
await page.waitForTimeout(300);
await assertTitleTexts(page, 'test123456');
await assertTitle(page, 'test123456');
});
});
test.describe('Search and select', () => {
test('Enter a keyword to search for', async ({ page }) => {
await newPage(page);
await openQuickSearchByShortcut(page);
await page.keyboard.insertText('test123456');
const actual = await page.locator('[cmdk-input]').inputValue();
expect(actual).toBe('test123456');
});
test('Create a new page and search this page', async ({ page }) => {
await newPage(page);
await openQuickSearchByShortcut(page);
@@ -85,13 +88,13 @@ test.describe('Search and select', () => {
const addNewPage = page.locator('[data-testid=quickSearch-addNewPage]');
await addNewPage.click();
await page.waitForTimeout(300);
await assertTitleTexts(page, 'test123456');
await assertTitle(page, 'test123456');
await openQuickSearchByShortcut(page);
await page.keyboard.insertText('test123456');
await assertResultList(page, ['test123456']);
await page.keyboard.press('Enter');
await page.waitForTimeout(300);
await assertTitleTexts(page, 'test123456', true);
await assertTitle(page, 'test123456');
});
});
test.describe('Disable search on 404 page', () => {
@@ -114,3 +117,28 @@ test.describe('Open quick search on the published page', () => {
await expect(publishedSearchResults).toBeVisible({ visible: false });
});
});
test.describe('Focus event for quick search', () => {
test('Autofocus input after opening quick search', async ({ page }) => {
await newPage(page);
await openQuickSearchByShortcut(page);
const locator = page.locator('[cmdk-input]');
await expect(locator).toBeVisible();
await expect(locator).toBeFocused();
});
test('Autofocus input after select', async ({ page }) => {
await newPage(page);
await openQuickSearchByShortcut(page);
await page.keyboard.press('ArrowUp');
const locator = page.locator('[cmdk-input]');
await expect(locator).toBeVisible();
await expect(locator).toBeFocused();
});
test('Focus title after creating a new page', async ({ page }) => {
await newPage(page);
await openQuickSearchByShortcut(page);
const addNewPage = page.locator('[data-testid=quickSearch-addNewPage]');
await addNewPage.click();
await titleIsFocused(page);
});
});