diff --git a/apps/web/src/atoms/first-load.ts b/apps/web/src/atoms/first-load.ts index 8c5f0e48cd..aeac04cfc5 100644 --- a/apps/web/src/atoms/first-load.ts +++ b/apps/web/src/atoms/first-load.ts @@ -1,10 +1,12 @@ +import { config } from '@affine/env'; import { atomWithStorage } from 'jotai/utils'; export type Visibility = Record; -const DEFAULT_VALUE = '0.0.0'; - -export const lastVersionAtom = atomWithStorage('lastVersion', DEFAULT_VALUE); +export const lastVersionAtom = atomWithStorage( + 'lastVersion', + config.gitVersion +); export const guideHiddenAtom = atomWithStorage('guideHidden', {}); diff --git a/apps/web/src/hooks/__tests__/index.spec.tsx b/apps/web/src/hooks/__tests__/index.spec.tsx index 2be0571802..8a762b76e3 100644 --- a/apps/web/src/hooks/__tests__/index.spec.tsx +++ b/apps/web/src/hooks/__tests__/index.spec.tsx @@ -5,6 +5,7 @@ import 'fake-indexeddb/auto'; import assert from 'node:assert'; +import { config } from '@affine/env'; import { rootCurrentWorkspaceIdAtom, rootWorkspacesMetadataAtom, @@ -282,7 +283,7 @@ describe('useIsFirstLoad', () => { test('useLastVersion', async () => { const lastVersion = renderHook(() => useLastVersion()); const setLastVersion = lastVersion.result.current[1]; - expect(lastVersion.result.current[0]).toEqual('0.0.0'); + expect(lastVersion.result.current[0]).toEqual(config.gitVersion); setLastVersion('testVersion'); lastVersion.rerender(); expect(lastVersion.result.current[0]).toEqual('testVersion'); diff --git a/apps/web/src/hooks/use-is-first-load.ts b/apps/web/src/hooks/use-is-first-load.ts index 3436f8f7e9..818127c8c3 100644 --- a/apps/web/src/hooks/use-is-first-load.ts +++ b/apps/web/src/hooks/use-is-first-load.ts @@ -45,7 +45,6 @@ export function useTipsDisplayStatus() { export function useUpdateTipsOnVersionChange() { const [lastVersion, setLastVersion] = useLastVersion(); - const currentVersion = config.gitVersion; const tipsDisplayStatus = useTipsDisplayStatus(); const setPermanentlyHiddenTips = useSetAtom(guideHiddenAtom); const setHiddenUntilNextUpdateTips = useSetAtom( @@ -53,6 +52,7 @@ export function useUpdateTipsOnVersionChange() { ); useEffect(() => { + const currentVersion = config.gitVersion; if (lastVersion !== currentVersion) { setLastVersion(currentVersion); const newHiddenUntilNextUpdateTips = { ...TIPS }; @@ -64,7 +64,6 @@ export function useUpdateTipsOnVersionChange() { setPermanentlyHiddenTips(newPermanentlyHiddenTips); } }, [ - currentVersion, lastVersion, setLastVersion, setPermanentlyHiddenTips,