fix: add prefer-dom-node-remove rule (#5112)

This commit is contained in:
LongYinan
2023-11-29 04:43:50 +00:00
parent 45690c2756
commit 4dddbbdaee
6 changed files with 8 additions and 7 deletions

View File

@@ -177,7 +177,7 @@ const EditorWrapper = memo(function EditorWrapper({
document.body.append(div);
return () => {
cleanup();
document.body.removeChild(div);
div.remove();
};
});
});
@@ -238,11 +238,11 @@ const PluginContentAdapter = memo<PluginContentAdapterProps>(
root.append(div);
if (abortController.signal.aborted) {
cleanup();
root.removeChild(div);
div.remove();
} else {
const cl = () => {
cleanup();
root.removeChild(div);
div.remove();
};
const dispose = addCleanup(pluginName, cl);
abortController.signal.addEventListener('abort', () => {

View File

@@ -30,7 +30,7 @@ export const PluginHeader = () => {
pluginsRef.current = pluginsRef.current.filter(
name => name !== pluginName
);
root.removeChild(div);
div.remove();
cleanup();
});
});