Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-12 04:18:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): page jumps unexpectedly when clicking the collection operation (#8182)

Browse Source 
close AF-1371

https://github.com/user-attachments/assets/9cc25790-8755-458c-94ac-a8d1b584c428
This commit is contained in:
JimmFly
2024-09-10 06:38:33 +00:00
parent 0cdc486f1f
commit 4c0d0ab8de
1 changed files with 42 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
packages/frontend/core/src/components/page-list/operation-cell.tsx
View File

@@ -35,6 +35,7 @@ import {
useServices,
WorkspaceService,
} from '@toeverything/infra';
import type { MouseEvent } from 'react';
import { useCallback, useState } from 'react';
import type { CollectionService } from '../../modules/collection';
@@ -324,29 +325,48 @@ export const CollectionOperationCell = ({
title: t['com.affine.editCollection.renameCollection'](),
});
const handleEditName = useCallback(() => {
// use openRenameModal if it is in the sidebar collection list
openEditCollectionNameModal(collection.name)
.then(name => {
return service.updateCollection(collection.id, collection => ({
...collection,
name,
}));
})
.catch(err => {
console.error(err);
});
}, [collection.id, collection.name, openEditCollectionNameModal, service]);
const handlePropagation = useCallback((event: MouseEvent) => {
event.preventDefault();
event.stopPropagation();
}, []);
const handleEdit = useCallback(() => {
openEditCollectionModal(collection)
.then(collection => {
return service.updateCollection(collection.id, () => collection);
})
.catch(err => {
console.error(err);
});
}, [openEditCollectionModal, collection, service]);
const handleEditName = useCallback(
(event: MouseEvent) => {
handlePropagation(event);
// use openRenameModal if it is in the sidebar collection list
openEditCollectionNameModal(collection.name)
.then(name => {
return service.updateCollection(collection.id, collection => ({
...collection,
name,
}));
})
.catch(err => {
console.error(err);
});
},
[
collection.id,
collection.name,
handlePropagation,
openEditCollectionNameModal,
service,
]
);
const handleEdit = useCallback(
(event: MouseEvent) => {
handlePropagation(event);
openEditCollectionModal(collection)
.then(collection => {
return service.updateCollection(collection.id, () => collection);
})
.catch(err => {
console.error(err);
});
},
[handlePropagation, openEditCollectionModal, collection, service]
);
const handleDelete = useCallback(() => {
return service.deleteCollection(info, collection.id);