fix(electron): optimize find in page in electron (2) (#9901)

1. find in page should have higher z-index than other modals
2. fix focused texts are not automatically being used as the default input value for searching
This commit is contained in:
pengx17
2025-01-27 07:58:16 +00:00
parent ffbec1633e
commit 4b549e0484
4 changed files with 14 additions and 16 deletions

View File

@@ -9,12 +9,12 @@ import { useCallback, useEffect } from 'react';
export function useRegisterFindInPageCommands() {
const findInPage = useServiceOptional(FindInPageService)?.findInPage;
const toggleVisible = useCallback(() => {
const showFindInPage = useCallback(() => {
// get the selected text in page
const selection = window.getSelection();
const selectedText = selection?.toString();
findInPage?.toggleVisible(selectedText);
findInPage?.findInPage(selectedText);
}, [findInPage]);
useEffect(() => {
@@ -33,8 +33,7 @@ export function useRegisterFindInPageCommands() {
label: '',
run() {
track.$.cmdk.general.findInPage();
toggleVisible();
showFindInPage();
},
})
);
@@ -42,5 +41,5 @@ export function useRegisterFindInPageCommands() {
return () => {
unsubs.forEach(unsub => unsub());
};
}, [toggleVisible]);
}, [findInPage, showFindInPage]);
}