fix: some minor ui issues (#1783)

This commit is contained in:
Peng Xiao
2023-04-03 13:24:53 +08:00
committed by GitHub
parent 95879cc1d0
commit 487ef35563
10 changed files with 90 additions and 79 deletions

View File

@@ -9,8 +9,8 @@ test.describe('Layout ui', () => {
await openHomePage(page);
await waitMarkdownImported(page);
await page.getByTestId('sliderBar-arrowButton-collapse').click();
const sliderBarArea = page.getByTestId('sliderBar-inner');
await expect(sliderBarArea).not.toBeVisible();
const sliderBarArea = page.getByTestId('sliderBar-root');
await expect(sliderBarArea).not.toBeInViewport();
});
test('Expand Sidebar', async ({ page }) => {
@@ -18,10 +18,10 @@ test.describe('Layout ui', () => {
await waitMarkdownImported(page);
await page.getByTestId('sliderBar-arrowButton-collapse').click();
const sliderBarArea = page.getByTestId('sliderBar-inner');
await expect(sliderBarArea).not.toBeVisible();
await expect(sliderBarArea).not.toBeInViewport();
await page.getByTestId('sliderBar-arrowButton-expand').click();
await expect(sliderBarArea).toBeVisible();
await expect(sliderBarArea).toBeInViewport();
});
test('Click resizer can close sidebar', async ({ page }) => {
@@ -31,7 +31,7 @@ test.describe('Layout ui', () => {
await expect(sliderBarArea).toBeVisible();
await page.getByTestId('sliderBar-resizer').click();
await expect(sliderBarArea).not.toBeVisible();
await expect(sliderBarArea).not.toBeInViewport();
});
test('Drag resizer can resize sidebar', async ({ page }) => {
@@ -58,7 +58,7 @@ test.describe('Layout ui', () => {
const sliderBarModalBackground = page.getByTestId(
'sliderBar-modalBackground'
);
await expect(sliderBarArea).toBeVisible();
await expect(sliderBarArea).toBeInViewport();
await expect(sliderBarModalBackground).not.toBeVisible();
await page.setViewportSize({
@@ -72,6 +72,6 @@ test.describe('Layout ui', () => {
force: true,
position: { x: 600, y: 150 },
});
await expect(sliderBarArea).not.toBeVisible();
await expect(sliderBarArea).not.toBeInViewport();
});
});

View File

@@ -181,7 +181,7 @@ test.describe('Novice guidance for quick search', () => {
await expect(quickSearchTips).not.toBeVisible();
await page.getByTestId('sliderBar-arrowButton-collapse').click();
const sliderBarArea = page.getByTestId('sliderBar-inner');
await expect(sliderBarArea).not.toBeVisible();
await expect(sliderBarArea).not.toBeInViewport();
await expect(quickSearchTips).toBeVisible();
await page.locator('[data-testid=quick-search-got-it]').click();
await expect(quickSearchTips).not.toBeVisible();

View File

@@ -10,6 +10,6 @@ test.describe('subpage', () => {
await waitMarkdownImported(page);
await page.getByTestId('sliderBar-arrowButton-collapse').click();
const sliderBarArea = page.getByTestId('sliderBar-inner');
await expect(sliderBarArea).not.toBeVisible();
await expect(sliderBarArea).not.toBeInViewport();
});
});