fix: remove useRef in menu & tooltip (#4369)

This commit is contained in:
Qi
2023-09-16 03:29:55 +08:00
committed by GitHub
parent c41c3c81c8
commit 4577fb7e1a
18 changed files with 59 additions and 133 deletions

View File

@@ -151,7 +151,6 @@ export const Page = ({
workspace: Workspace;
allPageMeta: Record<string, PageMeta>;
}) => {
const ref = React.useRef(null);
const [collapsed, setCollapsed] = React.useState(true);
const params = useParams();
const { jumpToPage } = useNavigateHelper();
@@ -176,7 +175,6 @@ export const Page = ({
active={active}
collapsed={referencesToRender.length > 0 ? collapsed : undefined}
onCollapsedChange={setCollapsed}
ref={ref}
postfix={
<Menu
items={
@@ -189,9 +187,6 @@ export const Page = ({
workspace={workspace}
/>
}
portalOptions={{
container: ref.current,
}}
>
<IconButton
data-testid="collection-page-options"

View File

@@ -16,7 +16,6 @@ import {
type MouseEvent,
useCallback,
useMemo,
useState,
} from 'react';
import { useDatasourceSync } from '../../../../hooks/use-datasource-sync';
@@ -88,7 +87,6 @@ const WorkspaceStatus = ({
currentWorkspace.blockSuiteWorkspace
);
const setIsHovered = useSetAtom(hoverAtom);
const [container, setContainer] = useState<HTMLDivElement | null>(null);
const content = useMemo(() => {
if (currentWorkspace.flavour === WorkspaceFlavour.LOCAL) {
return 'Saved locally';
@@ -130,17 +128,11 @@ const WorkspaceStatus = ({
);
return (
<div style={{ display: 'flex' }}>
<Tooltip
content={content}
portalOptions={{
container,
}}
>
<Tooltip content={content}>
<StyledWorkspaceStatus
onMouseEnter={() => {
setIsHovered(true);
}}
ref={setContainer}
onMouseLeave={() => setIsHovered(false)}
onClick={handleClick}
>