Jayden/AFFiNE-Mirror
0
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-07-24 13:58:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove null type in hooks (#1955)

Browse Source
This commit is contained in:
Himself65
2023-04-16 21:36:32 -05:00
committed by GitHub
parent 9c517907eb
commit 3d70a36dd3
48 changed files with 149 additions and 181 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/src/hooks/__tests__/index.spec.tsx
+8 -5
View File
@@ -16,6 +16,10 @@ import { __unstableSchemas, AffineSchemas } from '@blocksuite/blocks/models';
import type { Page } from '@blocksuite/store';
import { assertExists } from '@blocksuite/store';
import { render, renderHook } from '@testing-library/react';
import {
useBlockSuitePageMeta,
usePageMetaHelper,
} from '@toeverything/hooks/use-block-suite-page-meta';
import { createStore, Provider } from 'jotai';
import { useRouter } from 'next/router';
import routerMock from 'next-router-mock';
@@ -36,7 +40,6 @@ import {
useLastVersion,
useTipsDisplayStatus,
} from '../use-is-first-load';
import { usePageMeta, usePageMetaHelper } from '../use-page-meta';
import {
useRecentlyViewed,
useSyncRecentViewsWithRouter,
@@ -103,7 +106,7 @@ beforeEach(async () => {
describe('usePageMetas', async () => {
test('basic', async () => {
const Component = () => {
const pageMetas = usePageMeta(blockSuiteWorkspace);
const pageMetas = useBlockSuitePageMeta(blockSuiteWorkspace);
return (
<div>
{pageMetas.map(meta => (
@@ -121,7 +124,7 @@ describe('usePageMetas', async () => {
test('mutation', () => {
const { result, rerender } = renderHook(() =>
usePageMeta(blockSuiteWorkspace)
useBlockSuitePageMeta(blockSuiteWorkspace)
);
expect(result.current.length).toBe(3);
expect(result.current[0].mode).not.exist;
@@ -143,7 +146,7 @@ describe('usePageMetas', async () => {
test('update title', () => {
const { result, rerender } = renderHook(() =>
usePageMeta(blockSuiteWorkspace)
useBlockSuitePageMeta(blockSuiteWorkspace)
);
expect(result.current.length).toBe(3);
expect(result.current[0].mode).not.exist;
@@ -260,7 +263,7 @@ describe('useRecentlyViewed', () => {
});
routerHook.rerender();
const syncHook = renderHook(
router => useSyncRecentViewsWithRouter(router),
router => useSyncRecentViewsWithRouter(router, blockSuiteWorkspace),
{
wrapper: ProviderWrapper,
initialProps: routerHook.result.current,
apps/web/src/hooks/__tests__/use-blocksuite-workspace-helper.spec.ts
-65
View File
@@ -1,65 +0,0 @@
/**
* @vitest-environment happy-dom
*/
import 'fake-indexeddb/auto';
import { __unstableSchemas, AffineSchemas } from '@blocksuite/blocks/models';
import type { Page } from '@blocksuite/store';
import { renderHook } from '@testing-library/react';
import { beforeEach, describe, expect, test } from 'vitest';
import { BlockSuiteWorkspace } from '../../shared';
import { useBlockSuiteWorkspaceHelper } from '../use-blocksuite-workspace-helper';
import { usePageMeta } from '../use-page-meta';
let blockSuiteWorkspace: BlockSuiteWorkspace;
function handleNewPage(page: Page) {
const pageBlockId = page.addBlock('affine:page', { title: '' });
const frameId = page.addBlock('affine:frame', {}, pageBlockId);
page.addBlock('affine:paragraph', {}, frameId);
}
beforeEach(() => {
blockSuiteWorkspace = new BlockSuiteWorkspace({
id: 'test',
})
.register(AffineSchemas)
.register(__unstableSchemas);
handleNewPage(blockSuiteWorkspace.createPage('page0'));
handleNewPage(blockSuiteWorkspace.createPage('page1'));
handleNewPage(blockSuiteWorkspace.createPage('page2'));
});
describe('useBlockSuiteWorkspaceHelper', () => {
test('should create page', () => {
expect(blockSuiteWorkspace.meta.pageMetas.length).toBe(3);
const helperHook = renderHook(() =>
useBlockSuiteWorkspaceHelper(blockSuiteWorkspace)
);
const pageMetaHook = renderHook(() => usePageMeta(blockSuiteWorkspace));
expect(pageMetaHook.result.current.length).toBe(3);
expect(blockSuiteWorkspace.meta.pageMetas.length).toBe(3);
const page = helperHook.result.current.createPage('page4');
expect(page.id).toBe('page4');
expect(blockSuiteWorkspace.meta.pageMetas.length).toBe(4);
pageMetaHook.rerender();
expect(pageMetaHook.result.current.length).toBe(4);
});
test('milestone', async () => {
expect(blockSuiteWorkspace.meta.pageMetas.length).toBe(3);
const helperHook = renderHook(() =>
useBlockSuiteWorkspaceHelper(blockSuiteWorkspace)
);
await helperHook.result.current.markMilestone('test');
expect(blockSuiteWorkspace.meta.pageMetas.length).toBe(3);
handleNewPage(helperHook.result.current.createPage('page4'));
expect(blockSuiteWorkspace.meta.pageMetas.length).toBe(4);
expect(await helperHook.result.current.listMilestone()).toHaveProperty(
'test'
);
await helperHook.result.current.revertMilestone('test');
expect(blockSuiteWorkspace.meta.pageMetas.length).toBe(3);
});
});