From 3bf2503f550951434fe156a03c6f5b504d78df1c Mon Sep 17 00:00:00 2001
From: George Kapetanakis <115373824+gkapetanakis@users.noreply.github.com>
Date: Wed, 18 Mar 2026 17:36:41 -0400
Subject: [PATCH] fix(tools): improve sed error handling in set-version script
 (#14684)

## Summary
Replace post-command status checks with inline failure handling around
`sed` calls.
In the stream update path, ensure the two `sed` operations are treated
as one success/failure unit.
Keep behavior and file outputs the same on success, while making failure
handling explicit.

## Why
When `set -e` is enabled (which the script itself enables) command
failures cause the script to exit, making error handling by checking
`$?` not work.

## Files affected
- `set-version.sh`

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Refactor**
* Enhanced error handling in version management script with improved
failure reporting and context information.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 scripts/set-version.sh | 27 +++++++++++----------------
 1 file changed, 11 insertions(+), 16 deletions(-)

diff --git a/scripts/set-version.sh b/scripts/set-version.sh
index 28e8757f38..38cde249f3 100755
--- a/scripts/set-version.sh
+++ b/scripts/set-version.sh
@@ -24,13 +24,11 @@ update_app_version_in_helm_charts() {
   echo "Updating $file_path with appVersion $new_version"
 
   # Use sed to replace the appVersion value with the new version.
-  sed -i.bak -E "s/^appVersion:[[:space:]]+[\"']?.*[\"']?$/appVersion: \"$new_version\"/" "$file_path"
-
-  # Check if sed command succeeded
-  if [ $? -ne 0 ]; then
-    echo "Error: Failed to update the appVersion."
+  sed -i.bak -E "s/^appVersion:[[:space:]]+[\"']?.*[\"']?$/appVersion: \"$new_version\"/" "$file_path" || {
+    # If the sed command fails, print an error message and exit with a non-zero status
+    echo "Error: Failed to update the appVersion in $file_path."
     return 1
-  fi
+  }
 
   echo "appVersion in $file_path updated to $new_version"
 
@@ -58,13 +56,12 @@ update_app_stream_version() {
   current_date=$(date +"%Y-%m-%d")
 
   # Use sed to update the version, date, and URL in the releases section
-  sed -i.bak -E "s|<release version=\"[^\"]*\" date=\"[^\"]*\">|<release version=\"$new_version\" date=\"$current_date\">|" "$file_path"
-  sed -i.bak -E "s|<url>https://github.com/toeverything/AFFiNE/releases/tag/v[^<]*</url>|<url>https://github.com/toeverything/AFFiNE/releases/tag/v$new_version</url>|" "$file_path"
-
-  if [ $? -ne 0 ]; then
+  sed -i.bak -E "s|<release version=\"[^\"]*\" date=\"[^\"]*\">|<release version=\"$new_version\" date=\"$current_date\">|" "$file_path" &&
+  sed -i.bak -E "s|<url>https://github.com/toeverything/AFFiNE/releases/tag/v[^<]*</url>|<url>https://github.com/toeverything/AFFiNE/releases/tag/v$new_version</url>|" "$file_path" || {
+    # If the sed command fails, print an error message and exit with a non-zero status
     echo "Error: Failed to update the appVersion."
     return 1
-  fi
+  }
 
   echo "appVersion in $file_path updated to $new_version"
 
@@ -85,13 +82,11 @@ update_ios_marketing_version() {
   echo "Updating $file_path with MARKETING_VERSION $new_version"
 
   # Use sed to replace the MARKETING_VERSION value with the new version
-  sed -i.bak -E "s/MARKETING_VERSION = [^;]*;/MARKETING_VERSION = $new_version;/g" "$file_path"
-
-  # Check if sed command succeeded
-  if [ $? -ne 0 ]; then
+  sed -i.bak -E "s/MARKETING_VERSION = [^;]*;/MARKETING_VERSION = $new_version;/g" "$file_path" || {
+    # If the sed command fails, print an error message and exit with a non-zero status
     echo "Error: Failed to update the MARKETING_VERSION."
     return 1
-  fi
+  }
 
   echo "MARKETING_VERSION in $file_path updated to $new_version"