build(electron): use nx (#2942)

apps/electron/package.json

@@ -11,8 +11,7 @@
   "homepage": "https://github.com/toeverything/AFFiNE",
   "scripts": {
     "dev": "yarn cross-env DEV_SERVER_URL=http://localhost:8080 node scripts/dev.mjs",
-    "watch": "yarn cross-env DEV_SERVER_URL=http://localhost:8080 node scripts/dev.mjs --watch",
-    "prod": "yarn node scripts/dev.mjs",
+    "dev:prod": "yarn node scripts/dev.mjs",
     "build": "zx scripts/build-layers.mjs",
     "generate-assets": "zx scripts/generate-assets.mjs",
     "package": "electron-forge package",
@@ -23,11 +22,9 @@
     "forge": "./forge.config.js"
   },
   "main": "./dist/main.js",
-  "exports": {
-    "./scripts/plugins/build-plugins.mjs": "./scripts/plugins/build-plugins.mjs"
-  },
   "devDependencies": {
     "@affine-test/kit": "workspace:*",
+    "@affine/bookmark-block": "workspace:*",
     "@affine/native": "workspace:*",
     "@blocksuite/blocks": "0.0.0-20230629103121-76e6587d-nightly",
     "@blocksuite/editor": "0.0.0-20230629103121-76e6587d-nightly",
@@ -50,7 +47,7 @@
     "electron-log": "^5.0.0-beta.24",
     "electron-squirrel-startup": "1.0.0",
     "electron-window-state": "^5.0.3",
-    "esbuild": "^0.18.9",
+    "esbuild": "^0.18.10",
     "fs-extra": "^11.1.1",
     "jotai": "^2.2.1",
     "playwright": "=1.33.0",

apps/electron/scripts/build-layers.mjs

@@ -1,12 +1,9 @@
 #!/usr/bin/env zx
 import 'zx/globals';
 
-import { resolve } from 'node:path';
-
-import { spawnSync } from 'child_process';
 import * as esbuild from 'esbuild';
 
-import { config, rootDir } from './common.mjs';
+import { config } from './common.mjs';
 
 const NODE_ENV =
   process.env.NODE_ENV === 'development' ? 'development' : 'production';
@@ -18,20 +15,10 @@ if (process.platform === 'win32') {
 
 async function buildLayers() {
   const common = config();
-  console.log('Build plugin infra');
-  spawnSync('yarn', ['build'], {
-    stdio: 'inherit',
-    cwd: resolve(rootDir, './packages/plugin-infra'),
-  });
-
-  console.log('Build plugins');
-  await import('./plugins/build-plugins.mjs');
-
   await esbuild.build(common.workers);
   await esbuild.build({
     ...common.layers,
     define: {
-      ...common.define,
       'process.env.NODE_ENV': `"${NODE_ENV}"`,
       'process.env.BUILD_TYPE': `"${process.env.BUILD_TYPE || 'stable'}"`,
     },

apps/electron/scripts/common.mjs

@@ -15,16 +15,9 @@ const DEV_SERVER_URL = process.env.DEV_SERVER_URL;
 /** @type 'production' | 'development'' */
 const mode = (process.env.NODE_ENV = process.env.NODE_ENV || 'development');
 
-// List of env that will be replaced by esbuild
-const ENV_MACROS = ['AFFINE_GOOGLE_CLIENT_ID', 'AFFINE_GOOGLE_CLIENT_SECRET'];
-
 /** @return {{layers: import('esbuild').BuildOptions, workers: import('esbuild').BuildOptions}} */
 export const config = () => {
   const define = Object.fromEntries([
-    ...ENV_MACROS.map(key => [
-      'process.env.' + key,
-      JSON.stringify(process.env[key] ?? ''),
-    ]),
     ['process.env.NODE_ENV', `"${mode}"`],
     ['process.env.USE_WORKER', '"true"'],
   ]);

apps/electron/scripts/dev.mjs

@@ -1,13 +1,12 @@
 /* eslint-disable no-async-promise-executor */
 import { spawn } from 'node:child_process';
 import { readFileSync } from 'node:fs';
-import path, { resolve } from 'node:path';
+import path from 'node:path';
 
 import electronPath from 'electron';
 import * as esbuild from 'esbuild';
-import which from 'which';
 
-import { config, electronDir, rootDir } from './common.mjs';
+import { config, electronDir } from './common.mjs';
 
 // this means we don't spawn electron windows, mainly for testing
 const watchMode = process.argv.includes('--watch');
@@ -68,14 +67,6 @@ function spawnOrReloadElectron() {
 }
 
 const common = config();
-const yarnPath = which.sync('yarn');
-async function watchPlugins() {
-  spawn(yarnPath, ['dev'], {
-    stdio: 'inherit',
-    cwd: resolve(rootDir, './packages/plugin-infra'),
-  });
-  await import('./plugins/dev-plugins.mjs');
-}
 
 async function watchLayers() {
   return new Promise(async resolve => {
@@ -134,7 +125,6 @@ async function watchWorkers() {
 }
 
 async function main() {
-  await watchPlugins();
   await watchLayers();
   await watchWorkers();
 

apps/electron/scripts/plugins/build-plugins.mjs

@@ -1,20 +0,0 @@
-#!/usr/bin/env node
-import { build } from 'esbuild';
-
-import { definePluginServerConfig } from './utils.mjs';
-
-await build({
-  ...definePluginServerConfig('bookmark-block'),
-  external: [
-    // server.ts
-    'link-preview-js',
-    // ui.ts
-    '@toeverything/plugin-infra',
-    '@affine/component',
-    '@blocksuite/store',
-    '@blocksuite/blocks',
-    'react',
-    'react-dom',
-    'foxact',
-  ],
-});

apps/electron/scripts/plugins/dev-plugins.mjs

@@ -1,22 +0,0 @@
-#!/usr/bin/env node
-import { context } from 'esbuild';
-
-import { definePluginServerConfig } from './utils.mjs';
-
-const plugin = await context({
-  ...definePluginServerConfig('bookmark-block'),
-  external: [
-    // server.ts
-    'link-preview-js',
-    // ui.ts
-    '@toeverything/plugin-infra',
-    '@affine/component',
-    '@blocksuite/store',
-    '@blocksuite/blocks',
-    'react',
-    'react-dom',
-    'foxact',
-  ],
-});
-
-await plugin.watch();

apps/electron/scripts/plugins/utils.mjs

@@ -1,34 +0,0 @@
-import { resolve } from 'node:path';
-import { fileURLToPath } from 'node:url';
-
-export const rootDir = fileURLToPath(new URL('../../../..', import.meta.url));
-export const electronOutputDir = resolve(
-  rootDir,
-  'apps',
-  'electron',
-  'dist',
-  'plugins'
-);
-export const pluginDir = resolve(rootDir, 'plugins');
-
-/**
- *
- * @param pluginDirName {string}
- * @return {import('esbuild').BuildOptions}
- */
-export function definePluginServerConfig(pluginDirName) {
-  const pluginRootDir = resolve(pluginDir, pluginDirName);
-  const mainEntryFile = resolve(pluginRootDir, 'src/index.ts');
-  const serverOutputDir = resolve(electronOutputDir, pluginDirName);
-  return {
-    entryPoints: [mainEntryFile],
-    platform: 'neutral',
-    format: 'esm',
-    outExtension: {
-      '.js': '.mjs',
-    },
-    outdir: serverOutputDir,
-    bundle: true,
-    splitting: true,
-  };
-}

apps/electron/tsconfig.node.json

@@ -9,5 +9,5 @@
     "allowSyntheticDefaultImports": true,
     "noEmit": false
   },
-  "include": ["./scripts"]
+  "include": ["./scripts", "esbuild.main.config.ts", "esbuild.plugin.config.ts"]
 }