Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-12 12:28:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(component): cmdk flaky (#4512)

Browse Source
This commit is contained in:
Peng Xiao
2023-09-27 09:37:00 +08:00
committed by GitHub
parent 4a03fa65d1
commit 369db3fea5
4 changed files with 23 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/core/src/components/blocksuite/block-suite-page-list/utils.tsx
View File

@@ -19,14 +19,14 @@ export const usePageHelper = (blockSuiteWorkspace: BlockSuiteWorkspace) => {
);
const setPageMode = useSetAtom(setPageModeAtom);
const createPageAndOpen = useCallback(
(id?: string, mode?: 'page' | 'edgeless'): string => {
(id?: string, mode?: 'page' | 'edgeless') => {
const page = createPage(id);
initEmptyPage(page).catch(error => {
toast(`Failed to initialize Page: ${error.message}`);
});
setPageMode(page.id, mode || 'page');
openPage(blockSuiteWorkspace.id, page.id);
return page.id;
return page;
},
[blockSuiteWorkspace.id, createPage, openPage, setPageMode]
);

20
apps/core/src/components/pure/cmdk/data.tsx
View File

@@ -243,12 +243,10 @@ export const usePageCommands = () => {
),
value: 'affine::create-page' + query, // hack to make the page always showing in the search result
category: 'affine:creation',
run: () => {
const pageId = pageHelper.createPage();
// need to wait for the page to be created
setTimeout(() => {
pageMetaHelper.setPageTitle(pageId, query);
});
run: async () => {
const page = pageHelper.createPage();
await page.waitForLoaded();
pageMetaHelper.setPageTitle(page.id, query);
},
icon: <PageIcon />,
});
@@ -265,12 +263,10 @@ export const usePageCommands = () => {
),
value: 'affine::create-edgeless' + query, // hack to make the page always showing in the search result
category: 'affine:creation',
run: () => {
const pageId = pageHelper.createEdgeless();
// need to wait for the page to be created
setTimeout(() => {
pageMetaHelper.setPageTitle(pageId, query);
});
run: async () => {
const page = pageHelper.createEdgeless();
await page.waitForLoaded();
pageMetaHelper.setPageTitle(page.id, query);
},
icon: <EdgelessIcon />,
});

5
apps/core/src/components/pure/workspace-slider-bar/favorite/add-favourite-button.tsx
View File

@@ -14,8 +14,9 @@ export const AddFavouriteButton = ({ workspace }: AddFavouriteButtonProps) => {
const { createPage } = usePageHelper(workspace);
const { setPageMeta } = usePageMetaHelper(workspace);
const handleAddFavorite = useCallback(async () => {
const id = createPage();
setPageMeta(id, { favorite: true });
const page = createPage();
await page.waitForLoaded();
setPageMeta(page.id, { favorite: true });
}, [createPage, setPageMeta]);
return (