From 363699a175700591b51c76bf59574d33060c45f8 Mon Sep 17 00:00:00 2001
From: danielchim <kahungchim@gmail.com>
Date: Sat, 22 Jul 2023 21:03:18 +0800
Subject: [PATCH] feat: title editing on workspace title (#3139)

Co-authored-by: Alex Yang <himself65@outlook.com>
---
 .../blocksuite/workspace-header/index.tsx     | 61 +++++++++++++++++--
 .../affine-local/e2e/change-page-mode.spec.ts | 43 +++++++++++++
 2 files changed, 98 insertions(+), 6 deletions(-)

diff --git a/apps/core/src/components/blocksuite/workspace-header/index.tsx b/apps/core/src/components/blocksuite/workspace-header/index.tsx
index b6d07ed924..ef368a836f 100644
--- a/apps/core/src/components/blocksuite/workspace-header/index.tsx
+++ b/apps/core/src/components/blocksuite/workspace-header/index.tsx
@@ -1,5 +1,9 @@
+import { Button } from '@affine/component';
 import { assertExists } from '@blocksuite/global/utils';
-import { useBlockSuitePageMeta } from '@toeverything/hooks/use-block-suite-page-meta';
+import {
+  useBlockSuitePageMeta,
+  usePageMetaHelper,
+} from '@toeverything/hooks/use-block-suite-page-meta';
 import { useSetAtom } from 'jotai';
 import type {
   FC,
@@ -7,7 +11,7 @@ import type {
   PropsWithChildren,
   ReactElement,
 } from 'react';
-import { useRef } from 'react';
+import { useCallback, useRef, useState } from 'react';
 
 import { openQuickSearchModalAtom } from '../../../atoms';
 import { QuickSearchButton } from '../../pure/quick-search-button';
@@ -27,10 +31,25 @@ export const BlockSuiteEditorHeader: FC<
   const pageMeta = useBlockSuitePageMeta(workspace.blockSuiteWorkspace).find(
     meta => meta.id === currentPage?.id
   );
+  const pageTitleMeta = usePageMetaHelper(workspace.blockSuiteWorkspace);
+  const [isEditable, setIsEditable] = useState(false);
+  const inputRef = useRef<HTMLInputElement>(null);
+
+  const handleClick = useCallback(() => {
+    if (isEditable) {
+      setIsEditable(!isEditable);
+      const value = inputRef.current?.value;
+      if (value !== pageMeta?.title && currentPage) {
+        pageTitleMeta.setPageTitle(currentPage?.id, value || '');
+      }
+    } else {
+      setIsEditable(!isEditable);
+    }
+  }, [currentPage, isEditable, pageMeta?.title, pageTitleMeta]);
+
   const headerRef = useRef<HTMLDivElement>(null);
   assertExists(pageMeta);
-  const title = pageMeta.title;
-
+  const title = pageMeta?.title;
   return (
     <Header ref={headerRef} {...props}>
       {children}
@@ -46,8 +65,38 @@ export const BlockSuiteEditorHeader: FC<
                 }}
               />
             </div>
-            <div className={styles.title}>{title || 'Untitled'}</div>
-
+            <div>
+              {isEditable ? (
+                <div>
+                  <input
+                    autoFocus={true}
+                    className={styles.title}
+                    type="text"
+                    data-testid="title-content"
+                    defaultValue={pageMeta?.title}
+                    onBlur={handleClick}
+                    ref={inputRef}
+                  />
+                  <Button
+                    onClick={handleClick}
+                    data-testid="save-edit-button"
+                    style={{
+                      marginLeft: '12px',
+                    }}
+                  >
+                    Save
+                  </Button>
+                </div>
+              ) : (
+                <span
+                  data-testid="title-edit-button"
+                  onClick={handleClick}
+                  style={{ cursor: 'pointer' }}
+                >
+                  {title || 'Untitled'}
+                </span>
+              )}
+            </div>
             <div className={styles.searchArrowWrapper}>
               <QuickSearchButton
                 onClick={() => {
diff --git a/tests/affine-local/e2e/change-page-mode.spec.ts b/tests/affine-local/e2e/change-page-mode.spec.ts
index d69ad6cfd5..2b387240d0 100644
--- a/tests/affine-local/e2e/change-page-mode.spec.ts
+++ b/tests/affine-local/e2e/change-page-mode.spec.ts
@@ -62,3 +62,46 @@ test('Convert to edgeless by editor header items', async ({ page }) => {
   const edgeless = page.locator('affine-edgeless-page');
   expect(await edgeless.isVisible()).toBe(true);
 });
+
+test('Able to insert the title of an untitled page', async ({ page }) => {
+  await openHomePage(page);
+  await waitEditorLoad(page);
+  const titleBarTextContent = await page.getByTestId('title-edit-button');
+  await titleBarTextContent.click({ delay: 100 });
+  const titleContent = await page.getByTestId('title-content');
+  await titleContent.fill('test');
+  await page.getByTestId('save-edit-button').click({ delay: 100 });
+  expect(await titleBarTextContent.textContent()).toBe('test');
+});
+
+test('Able to edit the title of an existing page', async ({ page }) => {
+  await openHomePage(page);
+  await waitEditorLoad(page);
+  const titleBarTextContent = await page.getByTestId('title-edit-button');
+  await titleBarTextContent.click({ delay: 100 });
+  const titleContent = await page.getByTestId('title-content');
+  await titleContent.fill('test');
+  await page.getByTestId('save-edit-button').click({ delay: 100 });
+  expect(await titleBarTextContent.textContent()).toBe('test');
+  await titleBarTextContent.click({ delay: 100 });
+  await titleContent.fill('Sample text 2');
+  await page.getByTestId('save-edit-button').click({ delay: 100 });
+  expect(await titleBarTextContent.textContent()).toBe('Sample text 2');
+});
+
+test('Clearing out the title bar will remove the page title', async ({
+  page,
+}) => {
+  await openHomePage(page);
+  await waitEditorLoad(page);
+  const titleBarTextContent = await page.getByTestId('title-edit-button');
+  await titleBarTextContent.click({ delay: 100 });
+  const titleContent = await page.getByTestId('title-content');
+  await titleContent.fill('test');
+  await page.getByTestId('save-edit-button').click({ delay: 100 });
+  expect(await titleBarTextContent.textContent()).toBe('test');
+  await titleBarTextContent.click({ delay: 100 });
+  await titleContent.fill('');
+  await page.getByTestId('save-edit-button').click({ delay: 100 });
+  expect(await titleBarTextContent.textContent()).toBe('Untitled');
+});