fix: sidebar regression (#2195)

This commit is contained in:
Himself65
2023-04-28 15:02:47 -05:00
committed by GitHub
parent 73a7c01580
commit 31cccafb40
8 changed files with 50 additions and 30 deletions

View File

@@ -17,7 +17,7 @@ import {
import type { Page } from '@blocksuite/store';
import { useAtomValue } from 'jotai';
import type { ReactElement, UIEvent } from 'react';
import React, { useCallback, useEffect, useRef, useState } from 'react';
import React, { useCallback, useEffect, useState } from 'react';
import type { AllWorkspace } from '../../shared';
import ChangeLog from '../pure/workspace-slider-bar/changeLog';
@@ -75,15 +75,15 @@ export const RootAppSidebar = ({
}, [createPage, openPage]);
const sidebarOpen = useAtomValue(appSidebarOpenAtom);
useEffect(() => {
if (environment.isDesktop) {
if (environment.isDesktop && typeof sidebarOpen === 'boolean') {
window.apis?.onSidebarVisibilityChange(sidebarOpen);
}
}, [sidebarOpen]);
const ref = useRef<HTMLElement>(null);
const [ref, setRef] = useState<HTMLElement | null>(null);
return (
<>
<AppSidebar
ref={ref}
ref={setRef}
footer={
<StyledNewPageButton
data-testid="new-page-button"