From 2f02f0da2b64fd8609a9669185471939f0091de7 Mon Sep 17 00:00:00 2001 From: pengx17 Date: Thu, 22 Aug 2024 05:26:29 +0000 Subject: [PATCH] fix(electron): should not send switchSplitView event when clicking on the active view (#7944) --- .../src/modules/app-tabs-header/views/app-tabs-header.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/frontend/core/src/modules/app-tabs-header/views/app-tabs-header.tsx b/packages/frontend/core/src/modules/app-tabs-header/views/app-tabs-header.tsx index d69c30cf8c..78e0d52c42 100644 --- a/packages/frontend/core/src/modules/app-tabs-header/views/app-tabs-header.tsx +++ b/packages/frontend/core/src/modules/app-tabs-header/views/app-tabs-header.tsx @@ -133,6 +133,9 @@ const WorkbenchTab = ({ ); const onActivateView = useAsyncCallback( async (viewIdx: number) => { + if (viewIdx === activeViewIndex && tabActive) { + return; + } await tabsHeaderService.activateView?.(workbench.id, viewIdx); if (tabActive) { track.$.appTabsHeader.$.tabAction({ @@ -146,7 +149,7 @@ const WorkbenchTab = ({ }); } }, - [tabActive, tabsHeaderService, workbench.id] + [activeViewIndex, tabActive, tabsHeaderService, workbench.id] ); const handleAuxClick: MouseEventHandler = useCatchEventCallback( async e => {