Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-13 12:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(editor): cleanup ts-expect-error (#9369)

Browse Source
This commit is contained in:
Saul-Mirone
2024-12-27 05:14:23 +00:00
parent 908e3efd12
commit 2b27d62b0e
35 changed files with 84 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
blocksuite/framework/store/src/__tests__/collection.unit.spec.ts
View File

@@ -36,7 +36,7 @@ const spaceMetaId = 'meta';
function serializCollection(doc: BlockSuiteDoc): Record<string, any> {
const spaces = {};
doc.spaces.forEach((subDoc, key) => {
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
spaces[key] = subDoc.toJSON();
});
const json = doc.toJSON();
@@ -103,7 +103,7 @@ describe('basic', () => {
assert.equal(collection.isEmpty, false);
assert.equal(typeof actualDoc.createDate, 'number');
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
delete actualDoc.createDate;
assert.deepEqual(actual, {

2
blocksuite/framework/store/src/__tests__/doc.unit.spec.ts
View File

@@ -177,7 +177,7 @@ test('always get latest value in onChange', () => {
let value: unknown;
rootModel.propsUpdated.on(({ key }) => {
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
value = rootModel[key];
});

14
blocksuite/framework/store/src/__tests__/transformer.unit.spec.ts
View File

@@ -96,23 +96,23 @@ test('snapshot to model', async () => {
});
expect(model.flavour).toBe(rootModel.flavour);
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
expect(model.props.title).toBeInstanceOf(Text);
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
map.set('title', model.props.title.yText);
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
expect(model.props.title.toString()).toBe('doc title');
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
expect(model.props.style).toEqual({
color: 'red',
});
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
expect(model.props.count).toBe(3);
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
expect(model.props.items).toMatchObject([
{
id: 0,
@@ -125,7 +125,7 @@ test('snapshot to model', async () => {
},
]);
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
model.props.items.forEach((item, index) => {
expect(item.content).toBeInstanceOf(Text);
const key = `item:${index}:content`;

10
blocksuite/framework/store/src/__tests__/yjs.unit.spec.ts
View File

@@ -49,11 +49,11 @@ describe('blocksuite yjs', () => {
proxy.obj2 = { foo: 2, bar: { num: 3 } };
expect(map.get('obj2')).toBeInstanceOf(Y.Map);
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
expect(map.get('obj2').get('bar').get('num')).toBe(3);
proxy.obj2.bar.str = 'hello';
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
expect(map.get('obj2').get('bar').get('str')).toBe('hello');
proxy.obj3 = {};
@@ -105,7 +105,7 @@ describe('blocksuite yjs', () => {
proxy.inner.native.setValue(['hello', 'world', 'foo']);
expect(native.getValue()).toEqual(['hello', 'world', 'foo']);
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
expect(map.get('inner').get('native').get('value')).toEqual([
'hello',
'world',
@@ -114,10 +114,10 @@ describe('blocksuite yjs', () => {
const native2 = new Boxed(0);
proxy.inner.native2 = native2;
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
expect(map.get('inner').get('native2').get('value')).toBe(0);
native2.setValue(1);
// @ts-expect-error FIXME: ts error
// @ts-expect-error ignore
expect(map.get('inner').get('native2').get('value')).toBe(1);
});
});

2
blocksuite/framework/store/src/schema/base.ts
View File

@@ -150,7 +150,7 @@ function MagicProps(): {
const modelLabel = Symbol('model_label');
// @ts-expect-error FIXME: ts error
// @ts-expect-error allow magic props
export class BlockModel<
Props extends object = object,
PropsSignal extends object = SignaledProps<Props>,

14
blocksuite/framework/store/src/store/doc/block/sync-controller.ts
View File

@@ -46,12 +46,12 @@ export class SyncController {
const keyName = key.replace('prop:', '');
const proxy = this._getPropsProxy(keyName, value);
this._byPassUpdate(() => {
// @ts-expect-error FIXME: ts error
// @ts-expect-error allow magic props
this.model[keyName] = proxy;
const signalKey = `${keyName}$`;
this._mutex(() => {
if (signalKey in this.model) {
// @ts-expect-error FIXME: ts error
// @ts-expect-error allow magic props
this.model[signalKey].value = y2Native(value);
}
});
@@ -62,10 +62,10 @@ export class SyncController {
if (type.action === 'delete') {
const keyName = key.replace('prop:', '');
this._byPassUpdate(() => {
// @ts-expect-error FIXME: ts error
// @ts-expect-error allow magic props
delete this.model[keyName];
if (`${keyName}$` in this.model) {
// @ts-expect-error FIXME: ts error
// @ts-expect-error allow magic props
this.model[`${keyName}$`].value = undefined;
}
});
@@ -136,7 +136,7 @@ export class SyncController {
const value = data.value;
if (!this.model) return;
_mutex(() => {
// @ts-expect-error FIXME: ts error
// @ts-expect-error allow magic props
this.model[key] = value;
});
});
@@ -208,7 +208,7 @@ export class SyncController {
function setValue(target: BlockModel, p: string, value: unknown) {
_mutex(() => {
// @ts-expect-error FIXME: ts error
// @ts-expect-error allow magic props
target[`${p}$`].value = value;
});
}
@@ -222,7 +222,7 @@ export class SyncController {
const signalKey = `${name}$`;
if (signalKey in this.model) {
this._mutex(() => {
// @ts-expect-error FIXME: ts error
// @ts-expect-error allow magic props
this.model[signalKey].value = this.model[name];
});
}

4
blocksuite/framework/store/src/utils/utils.ts
View File

@@ -19,7 +19,7 @@ export function syncBlockProps(
if (SYS_KEYS.has(key)) return;
if (value === undefined) return;
// @ts-expect-error FIXME: ts error
// @ts-expect-error allow props
model[key] = value;
});
@@ -31,7 +31,7 @@ export function syncBlockProps(
return;
}
// @ts-expect-error FIXME: ts error
// @ts-expect-error allow props
model[key] = native2Y(value);
});
}