From 007e8d87ed8897f3ddea19aee9651a06005039ea Mon Sep 17 00:00:00 2001 From: tzhangchi Date: Fri, 23 Dec 2022 18:25:24 +0800 Subject: [PATCH 1/2] test: make the test of change-page-mode more stable --- tests/change-page-mode.spec.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/change-page-mode.spec.ts b/tests/change-page-mode.spec.ts index 42393d10fe..7d08f7caa3 100644 --- a/tests/change-page-mode.spec.ts +++ b/tests/change-page-mode.spec.ts @@ -11,10 +11,12 @@ test.describe('Change page mode(Paper or Edgeless)', () => { // mouse hover trigger animation for showing full switcher await page.mouse.move((box?.x ?? 0) + 5, (box?.y ?? 0) + 5); - - const edgelessButton = page.locator( - '[data-testid=editor-mode-switcher] [title=Edgeless]' - ); + await page.waitForTimeout(500); + const edgelessButton = page + .getByTestId('editor-mode-switcher') + .locator('div') + .filter({ hasText: 'Edgeless' }) + .first(); // page.getByText('Edgeless').click() await edgelessButton.click(); // // mouse move to edgeless button From c6dbe23c6070c07d47a5b59a531212c3934bd6aa Mon Sep 17 00:00:00 2001 From: tzhangchi Date: Fri, 23 Dec 2022 18:27:28 +0800 Subject: [PATCH 2/2] feat: change the cursor of the new page btn to pointer --- packages/app/src/components/workspace-slider-bar/style.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/app/src/components/workspace-slider-bar/style.ts b/packages/app/src/components/workspace-slider-bar/style.ts index 2cb6b4e53f..cf344b60fe 100644 --- a/packages/app/src/components/workspace-slider-bar/style.ts +++ b/packages/app/src/components/workspace-slider-bar/style.ts @@ -100,6 +100,9 @@ export const StyledNewPageButton = styled(StyledListItem)(() => { left: '0', right: '0', margin: 'auto', + ':hover': { + cursor: 'pointer', + }, }; });