fix: add prefer-dom-node-append rule (#5108)

This commit is contained in:
LongYinan
2023-11-29 04:43:39 +00:00
parent 123f091e5b
commit 23cfc58fe2
10 changed files with 12 additions and 11 deletions

View File

@@ -12,7 +12,7 @@ export const RootBlockHub = () => {
if (div.hasChildNodes()) {
div.removeChild(div.firstChild as ChildNode);
}
div.appendChild(blockHub);
div.append(blockHub);
}
}
}, [blockHub]);

View File

@@ -134,7 +134,7 @@ const BlockSuiteEditorImpl = ({
if (!container) {
return;
}
container.appendChild(editor);
container.append(editor);
return () => {
container.removeChild(editor);
};

View File

@@ -84,7 +84,7 @@ export const playCheckAnimation = async (refElement: Element) => {
border-radius: 50%;
font-size: inherit;
`;
refElement.appendChild(sparkingEl);
refElement.append(sparkingEl);
await sparkingEl.animate(
[

View File

@@ -46,7 +46,7 @@ const createToastContainer = (portal?: HTMLElement) => {
data-testid="affine-toast-container"
></div>`;
const element = htmlToElement<HTMLDivElement>(template);
portal.appendChild(element);
portal.append(element);
return element;
};
@@ -98,7 +98,7 @@ const createAndShowNewToast = (
const toastElement = htmlToElement<HTMLDivElement>(toastTemplate);
// message is not trusted
toastElement.textContent = message;
ToastContainer.appendChild(toastElement);
ToastContainer.append(toastElement);
logger.debug(`toast with message: "${message}"`);
window.dispatchEvent(
new CustomEvent('affine-toast:emit', { detail: message })