From 231956fd39f78cced9ec71760f4ea6caad7ce352 Mon Sep 17 00:00:00 2001
From: EYHN <cneyhn@gmail.com>
Date: Mon, 31 Mar 2025 08:38:29 +0000
Subject: [PATCH] feat(core): track for notifications (#11298)

---
 .../core/src/components/notification/list.tsx | 36 +++++++++++++++++--
 .../root-app-sidebar/notification-button.tsx  | 15 ++++++--
 packages/frontend/track/src/events.ts         | 15 +++++++-
 3 files changed, 60 insertions(+), 6 deletions(-)

diff --git a/packages/frontend/core/src/components/notification/list.tsx b/packages/frontend/core/src/components/notification/list.tsx
index 7def1fa4c5..0747035672 100644
--- a/packages/frontend/core/src/components/notification/list.tsx
+++ b/packages/frontend/core/src/components/notification/list.tsx
@@ -25,6 +25,7 @@ import type {
   MentionNotificationBodyType,
 } from '@affine/graphql';
 import { i18nTime, Trans, useI18n } from '@affine/i18n';
+import track from '@affine/track';
 import {
   CollaborationIcon,
   DeleteIcon,
@@ -176,6 +177,10 @@ const MentionNotificationItem = ({
   const memberInactived = !body.createdByUser;
 
   const handleClick = useCallback(() => {
+    track.$.sidebar.notifications.clickNotification({
+      type: notification.type,
+      item: 'read',
+    });
     if (!body.workspace?.id) {
       return;
     }
@@ -189,7 +194,7 @@ const MentionNotificationItem = ({
       body.doc.blockId ? [body.doc.blockId] : undefined,
       body.doc.elementId ? [body.doc.elementId] : undefined
     );
-  }, [body, jumpToPageBlock, notificationListService, notification.id]);
+  }, [body, jumpToPageBlock, notificationListService, notification]);
 
   return (
     <div className={styles.itemContainer} onClick={handleClick}>
@@ -241,6 +246,10 @@ const InvitationReviewRequestNotificationItem = ({
   const memberInactived = !body.createdByUser;
   const workspaceInactived = !body.workspace;
   const handleClick = useCallback(() => {
+    track.$.sidebar.notifications.clickNotification({
+      type: notification.type,
+      item: 'read',
+    });
     notificationListService.readNotification(notification.id).catch(err => {
       console.error(err);
     });
@@ -353,6 +362,11 @@ const InvitationReviewApprovedNotificationItem = ({
   const workspaceInactived = !body.workspace;
 
   const handleClick = useCallback(() => {
+    track.$.sidebar.notifications.clickNotification({
+      type: notification.type,
+      item: 'button',
+      button: 'open',
+    });
     notificationListService.readNotification(notification.id).catch(err => {
       console.error(err);
     });
@@ -424,6 +438,10 @@ const InvitationAcceptedNotificationItem = ({
   const memberInactived = !body.createdByUser;
 
   const handleClick = useCallback(() => {
+    track.$.sidebar.notifications.clickNotification({
+      type: notification.type,
+      item: 'read',
+    });
     notificationListService.readNotification(notification.id).catch(err => {
       console.error(err);
     });
@@ -476,6 +494,10 @@ const InvitationBlockedNotificationItem = ({
   const workspaceInactived = !body.workspace;
 
   const handleClick = useCallback(() => {
+    track.$.sidebar.notifications.clickNotification({
+      type: notification.type,
+      item: 'read',
+    });
     notificationListService.readNotification(notification.id).catch(err => {
       console.error(err);
     });
@@ -544,6 +566,11 @@ const InvitationNotificationItem = ({
   }, [body, jumpToPage, notification.id, notificationListService]);
 
   const handleAcceptInvite = useCallback(() => {
+    track.$.sidebar.notifications.clickNotification({
+      type: notification.type,
+      item: 'button',
+      button: 'accept',
+    });
     setIsAccepting(true);
     invitationService
       .acceptInvite(inviteId)
@@ -654,12 +681,17 @@ const DeleteButton = ({
     (e: React.MouseEvent<HTMLButtonElement>) => {
       e.stopPropagation(); // prevent trigger the click event of the parent element
 
+      track.$.sidebar.notifications.clickNotification({
+        type: notification.type,
+        item: 'dismiss',
+      });
+
       notificationListService.readNotification(notification.id).catch(err => {
         console.error(err);
       });
       onClick?.();
     },
-    [notificationListService, notification.id, onClick]
+    [notificationListService, notification, onClick]
   );
 
   return (
diff --git a/packages/frontend/core/src/components/root-app-sidebar/notification-button.tsx b/packages/frontend/core/src/components/root-app-sidebar/notification-button.tsx
index b67e637560..0d0082c72d 100644
--- a/packages/frontend/core/src/components/root-app-sidebar/notification-button.tsx
+++ b/packages/frontend/core/src/components/root-app-sidebar/notification-button.tsx
@@ -2,6 +2,7 @@ import { Menu } from '@affine/component';
 import { MenuItem } from '@affine/core/modules/app-sidebar/views';
 import { NotificationCountService } from '@affine/core/modules/notification';
 import { useI18n } from '@affine/i18n';
+import { track } from '@affine/track';
 import { NotificationIcon } from '@blocksuite/icons/rc';
 import { useLiveData, useService } from '@toeverything/infra';
 import { useCallback, useState } from 'react';
@@ -28,9 +29,17 @@ export const NotificationButton = () => {
 
   const [notificationListOpen, setNotificationListOpen] = useState(false);
 
-  const handleNotificationListOpenChange = useCallback((open: boolean) => {
-    setNotificationListOpen(open);
-  }, []);
+  const handleNotificationListOpenChange = useCallback(
+    (open: boolean) => {
+      if (open) {
+        track.$.sidebar.notifications.openInbox({
+          unreadCount: notificationCountService.count$.value,
+        });
+      }
+      setNotificationListOpen(open);
+    },
+    [notificationCountService.count$.value]
+  );
 
   return (
     <Menu
diff --git a/packages/frontend/track/src/events.ts b/packages/frontend/track/src/events.ts
index eeb5227c55..4a2ba279e7 100644
--- a/packages/frontend/track/src/events.ts
+++ b/packages/frontend/track/src/events.ts
@@ -145,6 +145,10 @@ type AttachmentEvents =
 type TemplateEvents = 'openTemplateListMenu';
 // END SECTION
 
+// SECTION: notification
+type NotificationEvents = 'openInbox' | 'clickNotification';
+// END SECTION
+
 type UserEvents =
   | GeneralEvents
   | AppEvents
@@ -162,7 +166,9 @@ type UserEvents =
   | PaymentEvents
   | DNDEvents
   | AttachmentEvents
-  | TemplateEvents;
+  | TemplateEvents
+  | NotificationEvents;
+
 interface PageDivision {
   [page: string]: {
     [segment: string]: {
@@ -346,6 +352,7 @@ const PageEvents = {
     sidebar: {
       newDoc: ['quickStart'],
       template: ['openTemplateListMenu', 'quickStart'],
+      notifications: ['openInbox', 'clickNotification'],
     },
     splitViewIndicator: {
       $: ['splitViewAction', 'openInSplitView', 'openInPeekView'],
@@ -543,6 +550,12 @@ export type EventArgs = {
   inviteUserDocRole: {
     control: 'member list';
   };
+  openInbox: { unreadCount: number };
+  clickNotification: {
+    type: string;
+    item: 'read' | 'button' | 'dismiss';
+    button?: string;
+  };
 };
 
 // for type checking