From 22a2a17837551ef22195a94cb207318527da1a82 Mon Sep 17 00:00:00 2001
From: QiShaoXuan <qishaoxuan777@gmail.com>
Date: Tue, 20 Dec 2022 10:23:41 +0800
Subject: [PATCH] fix: remove  warning

---
 packages/app/src/providers/app-state-provider/context.ts  | 7 +++----
 .../providers/app-state-provider/dynamic-blocksuite.tsx   | 8 +++-----
 packages/app/src/providers/app-state-provider/hooks.ts    | 4 ++--
 3 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/packages/app/src/providers/app-state-provider/context.ts b/packages/app/src/providers/app-state-provider/context.ts
index c29d3678fb..54ba26da23 100644
--- a/packages/app/src/providers/app-state-provider/context.ts
+++ b/packages/app/src/providers/app-state-provider/context.ts
@@ -1,10 +1,10 @@
 import { createContext, useContext } from 'react';
-import { AccessTokenMessage } from '@pathfinder/data-services';
 import type { Workspace } from '@pathfinder/data-services';
+import { AccessTokenMessage } from '@pathfinder/data-services';
 import type {
-  Workspace as StoreWorkspace,
   Page as StorePage,
   PageMeta,
+  Workspace as StoreWorkspace,
 } from '@blocksuite/store';
 import type { EditorContainer } from '@blocksuite/editor';
 
@@ -57,6 +57,5 @@ export const AppState = createContext<AppStateContext>({
 });
 
 export const useAppState = () => {
-  const state = useContext(AppState);
-  return state;
+  return useContext(AppState);
 };
diff --git a/packages/app/src/providers/app-state-provider/dynamic-blocksuite.tsx b/packages/app/src/providers/app-state-provider/dynamic-blocksuite.tsx
index d5dcc262d0..0b09c6f88c 100644
--- a/packages/app/src/providers/app-state-provider/dynamic-blocksuite.tsx
+++ b/packages/app/src/providers/app-state-provider/dynamic-blocksuite.tsx
@@ -1,13 +1,12 @@
 import { useEffect } from 'react';
+import type { Page } from '@blocksuite/store';
 import {
-  Workspace,
   createWebsocketDocProvider,
   IndexedDBDocProvider,
+  Workspace,
 } from '@blocksuite/store';
 import '@blocksuite/blocks';
 import '@blocksuite/blocks/style';
-
-import type { Page } from '@blocksuite/store';
 import { BlockSchema, createEditor } from '@blocksuite/editor';
 import type { AppStateContext } from './context';
 
@@ -66,8 +65,7 @@ const DynamicBlocksuite = ({
 
   useEffect(() => {
     const createEditorHandler: CreateEditorHandler = (page: Page) => {
-      const editor = createEditor(page);
-      return editor;
+      return createEditor(page);
     };
 
     setCreateEditorHandler(createEditorHandler);
diff --git a/packages/app/src/providers/app-state-provider/hooks.ts b/packages/app/src/providers/app-state-provider/hooks.ts
index 3ea5ac37c2..a2811228fc 100644
--- a/packages/app/src/providers/app-state-provider/hooks.ts
+++ b/packages/app/src/providers/app-state-provider/hooks.ts
@@ -10,7 +10,7 @@ export const useLoadWorkspace = () => {
 
   useEffect(() => {
     loadWorkspace?.(workspaceId);
-  }, [workspaceId]);
+  }, [loadWorkspace, workspaceId]);
 
   return currentWorkspaceId === workspaceId ? currentWorkspace : null;
 };
@@ -24,7 +24,7 @@ export const useLoadPage = () => {
 
   useEffect(() => {
     loadPage(pageId);
-  }, [workspace, pageId]);
+  }, [workspace, pageId, loadPage]);
 
   return currentPage?.pageId === pageId ? currentPage : null;
 };