fix(editor): move insert link command to bookmark to remove ts ignore (#9370)

blocksuite/affine/block-embed/src/effects.ts

@@ -12,11 +12,10 @@ import { EmbedHtmlBlockComponent } from './embed-html-block';
 import { EmbedHtmlFullscreenToolbar } from './embed-html-block/components/fullscreen-toolbar';
 import { EmbedEdgelessHtmlBlockComponent } from './embed-html-block/embed-edgeless-html-block';
 import { EmbedLinkedDocBlockComponent } from './embed-linked-doc-block';
-import type { insertEmbedLinkedDocCommand } from './embed-linked-doc-block/commands/insert-embed-linked-doc';
 import type {
   InsertedLinkType,
-  insertLinkByQuickSearchCommand,
-} from './embed-linked-doc-block/commands/insert-link-by-quick-search';
+  insertEmbedLinkedDocCommand,
+} from './embed-linked-doc-block/commands/insert-embed-linked-doc';
 import { EmbedEdgelessLinkedDocBlockComponent } from './embed-linked-doc-block/embed-edgeless-linked-doc-block';
 import type { EmbedLinkedDocBlockConfig } from './embed-linked-doc-block/embed-linked-doc-config';
 import {
@@ -121,15 +120,14 @@ declare global {
       'affine:embed-loom': EmbedLoomBlockService;
       'affine:embed-youtube': EmbedYoutubeBlockService;
     }
-    interface BlockConfigs {
-      'affine:embed-linked-doc': EmbedLinkedDocBlockConfig;
-    }
     interface CommandContext {
       insertedLinkType?: Promise<InsertedLinkType>;
     }
+    interface BlockConfigs {
+      'affine:embed-linked-doc': EmbedLinkedDocBlockConfig;
+    }
     interface Commands {
       insertEmbedLinkedDoc: typeof insertEmbedLinkedDocCommand;
-      insertLinkByQuickSearch: typeof insertLinkByQuickSearchCommand;
     }
   }
 }

blocksuite/affine/block-embed/src/embed-linked-doc-block/commands/index.ts

@@ -1,9 +1,9 @@
 import type { BlockCommands } from '@blocksuite/block-std';
 
 import { insertEmbedLinkedDocCommand } from './insert-embed-linked-doc.js';
-import { insertLinkByQuickSearchCommand } from './insert-link-by-quick-search.js';
 
 export const commands: BlockCommands = {
   insertEmbedLinkedDoc: insertEmbedLinkedDocCommand,
-  insertLinkByQuickSearch: insertLinkByQuickSearchCommand,
 };
+
+export type { InsertedLinkType } from './insert-embed-linked-doc';

blocksuite/affine/block-embed/src/embed-linked-doc-block/commands/insert-embed-linked-doc.ts

@@ -3,6 +3,10 @@ import type { Command } from '@blocksuite/block-std';
 
 import { insertEmbedCard } from '../../common/insert-embed-card.js';
 
+export type InsertedLinkType = {
+  flavour?: 'affine:bookmark' | 'affine:embed-linked-doc';
+} | null;
+
 export const insertEmbedLinkedDocCommand: Command<
   never,
   'insertedLinkType',

blocksuite/affine/block-embed/src/embed-linked-doc-block/commands/insert-link-by-quick-search.ts

@@ -1,48 +0,0 @@
-import { QuickSearchProvider } from '@blocksuite/affine-shared/services';
-import type { Command } from '@blocksuite/block-std';
-
-export type InsertedLinkType = {
-  flavour?: 'affine:bookmark' | 'affine:embed-linked-doc';
-} | null;
-
-export const insertLinkByQuickSearchCommand: Command<
-  never,
-  'insertedLinkType'
-> = (ctx, next) => {
-  const { std } = ctx;
-  const quickSearchService = std.getOptional(QuickSearchProvider);
-  if (!quickSearchService) {
-    next();
-    return;
-  }
-
-  const insertedLinkType: Promise<InsertedLinkType> = quickSearchService
-    .openQuickSearch()
-    .then(result => {
-      if (!result) return null;
-
-      // add linked doc
-      if ('docId' in result) {
-        std.command.exec('insertEmbedLinkedDoc', {
-          docId: result.docId,
-          params: result.params,
-        });
-        return {
-          flavour: 'affine:embed-linked-doc',
-        };
-      }
-
-      // add normal link;
-      if ('externalUrl' in result) {
-        // @ts-expect-error FIXME: fix after bookmark refactor
-        std.command.exec('insertBookmark', { url: result.externalUrl });
-        return {
-          flavour: 'affine:bookmark',
-        };
-      }
-
-      return null;
-    });
-
-  next({ insertedLinkType });
-};

blocksuite/affine/block-embed/src/embed-linked-doc-block/index.ts

@@ -1,4 +1,5 @@
-export * from './adapters/index.js';
-export * from './embed-linked-doc-block.js';
-export * from './embed-linked-doc-config.js';
-export * from './embed-linked-doc-spec.js';
+export * from './adapters';
+export type { InsertedLinkType } from './commands';
+export * from './embed-linked-doc-block';
+export * from './embed-linked-doc-config';
+export * from './embed-linked-doc-spec';