fix: add @typescript-eslint/no-floating-promises rule (#2764)

Co-authored-by: himself65 <himself65@outlook.com>

apps/web/src/atoms/history.ts

@@ -75,7 +75,9 @@ export function useHistoryAtom() {
           if (forward) {
             const target = Math.min(prev.stack.length - 1, prev.current + 1);
             const url = prev.stack[target];
-            void router.push(url);
+            router.push(url).catch(err => {
+              console.error(err);
+            });
             return {
               ...prev,
               current: target,
@@ -84,7 +86,9 @@ export function useHistoryAtom() {
           } else {
             const target = Math.max(0, prev.current - 1);
             const url = prev.stack[target];
-            void router.push(url);
+            router.push(url).catch(err => {
+              console.error(err);
+            });
             return {
               ...prev,
               current: target,

apps/web/src/atoms/index.ts

@@ -49,19 +49,24 @@ rootWorkspacesMetadataAtom.onMount = setAtom => {
   }, 0);
 
   if (environment.isDesktop) {
-    window.apis?.workspace.list().then(workspaceIDs => {
-      if (abortController.signal.aborted) return;
-      const newMetadata = workspaceIDs.map(w => ({
-        id: w[0],
-        flavour: WorkspaceFlavour.LOCAL,
-      }));
-      setAtom(metadata => {
-        return [
-          ...metadata,
-          ...newMetadata.filter(m => !metadata.find(m2 => m2.id === m.id)),
-        ];
+    window.apis?.workspace
+      .list()
+      .then(workspaceIDs => {
+        if (abortController.signal.aborted) return;
+        const newMetadata = workspaceIDs.map(w => ({
+          id: w[0],
+          flavour: WorkspaceFlavour.LOCAL,
+        }));
+        setAtom(metadata => {
+          return [
+            ...metadata,
+            ...newMetadata.filter(m => !metadata.find(m2 => m2.id === m.id)),
+          ];
+        });
+      })
+      .catch(err => {
+        console.error(err);
       });
-    });
   }
 
   return () => {

apps/web/src/components/affine/create-workspace-modal/index.tsx

@@ -116,9 +116,14 @@ const useDefaultDBLocation = () => {
   const [defaultDBLocation, setDefaultDBLocation] = useState('');
 
   useEffect(() => {
-    window.apis?.db.getDefaultStorageLocation().then(dir => {
-      setDefaultDBLocation(dir);
-    });
+    window.apis?.db
+      .getDefaultStorageLocation()
+      .then(dir => {
+        setDefaultDBLocation(dir);
+      })
+      .catch(err => {
+        console.error(err);
+      });
   }, []);
 
   return defaultDBLocation;
@@ -281,7 +286,9 @@ export const CreateWorkspaceModal = ({
           }
           onClose();
         }
-      })();
+      })().catch(err => {
+        console.error(err);
+      });
     } else if (mode === 'new') {
       setStep(environment.isDesktop ? 'set-db-location' : 'name-workspace');
     } else {

apps/web/src/components/affine/workspace-setting-detail/panel/general/index.tsx

@@ -12,7 +12,7 @@ import { useBlockSuiteWorkspaceAvatarUrl } from '@toeverything/hooks/use-block-s
 import { useBlockSuiteWorkspaceName } from '@toeverything/hooks/use-block-suite-workspace-name';
 import clsx from 'clsx';
 import type React from 'react';
-import { useEffect, useState } from 'react';
+import { useCallback, useEffect, useState } from 'react';
 
 import { useIsWorkspaceOwner } from '../../../../../hooks/affine/use-is-workspace-owner';
 import { Upload } from '../../../../pure/file-upload';
@@ -27,9 +27,14 @@ const useShowOpenDBFile = (workspaceId: string) => {
   const [show, setShow] = useState(false);
   useEffect(() => {
     if (window.apis && window.events && environment.isDesktop) {
-      window.apis.workspace.getMeta(workspaceId).then(meta => {
-        setShow(!!meta.secondaryDBPath);
-      });
+      window.apis.workspace
+        .getMeta(workspaceId)
+        .then(meta => {
+          setShow(!!meta.secondaryDBPath);
+        })
+        .catch(err => {
+          console.error(err);
+        });
       return window.events.workspace.onMetaChange((newMeta: any) => {
         if (newMeta.workspaceId === workspaceId) {
           const meta = newMeta.meta;
@@ -54,35 +59,11 @@ export const GeneralPanel: React.FC<PanelProps> = ({
   const isOwner = useIsWorkspaceOwner(workspace);
   const t = useAFFiNEI18N();
 
-  const showOpenFolder = useShowOpenDBFile(workspace.id);
-
   const handleUpdateWorkspaceName = (name: string) => {
     setName(name);
     toast(t['Update workspace name success']());
   };
 
-  const [moveToInProgress, setMoveToInProgress] = useState<boolean>(false);
-
-  const handleMoveTo = async () => {
-    if (moveToInProgress) {
-      return;
-    }
-    try {
-      setMoveToInProgress(true);
-      const result = await window.apis?.dialog.moveDBFile(workspace.id);
-      if (!result?.error && !result?.canceled) {
-        toast(t['Move folder success']());
-      } else if (result?.error) {
-        // @ts-expect-error: result.error is dynamic
-        toast(t[result.error]());
-      }
-    } catch (err) {
-      toast(t['UNKNOWN_ERROR']());
-    } finally {
-      setMoveToInProgress(false);
-    }
-  };
-
   const [, update] = useBlockSuiteWorkspaceAvatarUrl(
     workspace.blockSuiteWorkspace
   );
@@ -137,9 +118,7 @@ export const GeneralPanel: React.FC<PanelProps> = ({
             placeholder={t['Workspace Name']()}
             maxLength={64}
             minLength={0}
-            onChange={newName => {
-              setInput(newName);
-            }}
+            onChange={setInput}
           ></StyledInput>
         </div>
 
@@ -158,63 +137,7 @@ export const GeneralPanel: React.FC<PanelProps> = ({
           </Button>
         </div>
       </div>
-
-      {environment.isDesktop && (
-        <div className={style.row}>
-          <div className={style.col}>
-            <div className={style.settingItemLabel}>
-              {t['Storage Folder']()}
-            </div>
-            <div className={style.settingItemLabelHint}>
-              {t['Storage Folder Hint']()}
-            </div>
-          </div>
-
-          <div className={style.col}>
-            {showOpenFolder && (
-              <div
-                className={style.storageTypeWrapper}
-                onClick={() => {
-                  if (environment.isDesktop) {
-                    window.apis?.dialog.revealDBFile(workspace.id);
-                  }
-                }}
-              >
-                <FolderIcon color="var(--affine-primary-color)" />
-                <div className={style.storageTypeLabelWrapper}>
-                  <div className={style.storageTypeLabel}>
-                    {t['Open folder']()}
-                  </div>
-                  <div className={style.storageTypeLabelHint}>
-                    {t['Open folder hint']()}
-                  </div>
-                </div>
-                <ArrowRightSmallIcon color="var(--affine-primary-color)" />
-              </div>
-            )}
-
-            <div
-              data-testid="move-folder"
-              data-disabled={moveToInProgress}
-              className={style.storageTypeWrapper}
-              onClick={handleMoveTo}
-            >
-              <MoveToIcon color="var(--affine-primary-color)" />
-              <div className={style.storageTypeLabelWrapper}>
-                <div className={style.storageTypeLabel}>
-                  {t['Move folder']()}
-                </div>
-                <div className={style.storageTypeLabelHint}>
-                  {t['Move folder hint']()}
-                </div>
-              </div>
-              <ArrowRightSmallIcon color="var(--affine-primary-color)" />
-            </div>
-          </div>
-          <div className={style.col}></div>
-        </div>
-      )}
-
+      <DesktopClientOnly workspaceId={workspace.id} />
       <div className={style.row}>
         <div className={style.col}>
           <div className={style.settingItemLabel}>
@@ -273,3 +196,81 @@ export const GeneralPanel: React.FC<PanelProps> = ({
     </>
   );
 };
+
+function DesktopClientOnly({ workspaceId }: { workspaceId: string }) {
+  const t = useAFFiNEI18N();
+  const showOpenFolder = useShowOpenDBFile(workspaceId);
+  const onRevealDBFile = useCallback(() => {
+    if (environment.isDesktop) {
+      window.apis?.dialog.revealDBFile(workspaceId).catch(err => {
+        console.error(err);
+      });
+    }
+  }, [workspaceId]);
+  const [moveToInProgress, setMoveToInProgress] = useState<boolean>(false);
+  const handleMoveTo = useCallback(() => {
+    if (moveToInProgress) {
+      return;
+    }
+    setMoveToInProgress(true);
+    window.apis?.dialog
+      .moveDBFile(workspaceId)
+      .then(result => {
+        if (!result?.error && !result?.canceled) {
+          toast(t['Move folder success']());
+        } else if (result?.error) {
+          // @ts-expect-error: result.error is dynamic
+          toast(t[result.error]());
+        }
+      })
+      .catch(() => {
+        toast(t['UNKNOWN_ERROR']());
+      })
+      .finally(() => {
+        setMoveToInProgress(false);
+      });
+  }, [moveToInProgress, t, workspaceId]);
+  const openFolderNode = showOpenFolder ? (
+    <div className={style.storageTypeWrapper} onClick={onRevealDBFile}>
+      <FolderIcon color="var(--affine-primary-color)" />
+      <div className={style.storageTypeLabelWrapper}>
+        <div className={style.storageTypeLabel}>{t['Open folder']()}</div>
+        <div className={style.storageTypeLabelHint}>
+          {t['Open folder hint']()}
+        </div>
+      </div>
+      <ArrowRightSmallIcon color="var(--affine-primary-color)" />
+    </div>
+  ) : null;
+  return (
+    <div className={style.row}>
+      <div className={style.col}>
+        <div className={style.settingItemLabel}>{t['Storage Folder']()}</div>
+        <div className={style.settingItemLabelHint}>
+          {t['Storage Folder Hint']()}
+        </div>
+      </div>
+
+      <div className={style.col}>
+        {openFolderNode}
+
+        <div
+          data-testid="move-folder"
+          data-disabled={moveToInProgress}
+          className={style.storageTypeWrapper}
+          onClick={handleMoveTo}
+        >
+          <MoveToIcon color="var(--affine-primary-color)" />
+          <div className={style.storageTypeLabelWrapper}>
+            <div className={style.storageTypeLabel}>{t['Move folder']()}</div>
+            <div className={style.storageTypeLabelHint}>
+              {t['Move folder hint']()}
+            </div>
+          </div>
+          <ArrowRightSmallIcon color="var(--affine-primary-color)" />
+        </div>
+      </div>
+      <div className={style.col}></div>
+    </div>
+  );
+}

apps/web/src/components/blocksuite/workspace-header/header-right-items/language-menu.tsx

@@ -9,7 +9,9 @@ const LanguageMenuContent: FC = () => {
   const i18n = useI18N();
   const changeLanguage = useCallback(
     (event: string) => {
-      void i18n.changeLanguage(event);
+      i18n.changeLanguage(event).catch(err => {
+        console.error(err);
+      });
     },
     [i18n]
   );

apps/web/src/components/blocksuite/workspace-header/header.tsx

@@ -12,6 +12,7 @@ import type { PluginUIAdapter } from '@toeverything/plugin-infra/type';
 import { useAtom, useAtomValue } from 'jotai';
 import type { FC, HTMLAttributes, PropsWithChildren, ReactNode } from 'react';
 import { forwardRef, memo, useEffect, useMemo, useState } from 'react';
+import { noop } from 'rxjs';
 
 import { guideDownloadClientTipAtom } from '../../../atoms/guide';
 import { contentLayoutAtom } from '../../../atoms/layout';
@@ -104,27 +105,21 @@ const HeaderRightItems: Record<HeaderRightItemName, HeaderItem> = {
           <button
             data-type="minimize"
             className={styles.windowAppControl}
-            onClick={() => {
-              window.apis?.ui.handleMinimizeApp();
-            }}
+            onClick={window.apis?.ui.handleMinimizeApp ?? noop}
           >
             <MinusIcon />
           </button>
           <button
             data-type="maximize"
             className={styles.windowAppControl}
-            onClick={() => {
-              window.apis?.ui.handleMaximizeApp();
-            }}
+            onClick={window.apis?.ui.handleMaximizeApp ?? noop}
           >
             <RoundedRectangleIcon />
           </button>
           <button
             data-type="close"
             className={styles.windowAppControl}
-            onClick={() => {
-              window.apis?.ui.handleCloseApp();
-            }}
+            onClick={window.apis?.ui.handleCloseApp ?? noop}
           >
             <CloseIcon />
           </button>

apps/web/src/components/pure/quick-search-modal/footer.tsx

@@ -54,7 +54,9 @@ export const Footer: React.FC<FooterProps> = ({
           title: query,
         });
         onClose();
-        void jumpToPage(blockSuiteWorkspace.id, page.id);
+        jumpToPage(blockSuiteWorkspace.id, page.id).catch(err => {
+          console.error(err);
+        });
       }, [blockSuiteWorkspace, createPage, jumpToPage, onClose, query])}
     >
       <StyledModalFooterContent>

apps/web/src/components/root-app-sidebar/index.tsx

@@ -107,7 +107,9 @@ export const RootAppSidebar = ({
   const [sidebarOpen, setSidebarOpen] = useAtom(appSidebarOpenAtom);
   useEffect(() => {
     if (environment.isDesktop && typeof sidebarOpen === 'boolean') {
-      window.apis?.ui.handleSidebarVisibilityChange(sidebarOpen);
+      window.apis?.ui.handleSidebarVisibilityChange(sidebarOpen).catch(err => {
+        console.error(err);
+      });
     }
   }, [sidebarOpen]);
 

apps/web/src/layouts/workspace-layout.tsx

@@ -174,7 +174,9 @@ export const CurrentWorkspaceContext = ({
   useEffect(() => {
     const id = setTimeout(() => {
       if (!exist) {
-        void push('/');
+        push('/').catch(err => {
+          console.error(err);
+        });
         globalThis.HALTING_PROBLEM_TIMEOUT <<= 1;
       }
     }, globalThis.HALTING_PROBLEM_TIMEOUT);
@@ -319,7 +321,9 @@ export const WorkspaceLayoutInner: FC<PropsWithChildren> = ({ children }) => {
     }
     if (!router.query.pageId) {
       setCurrentPageId(pageId);
-      void jumpToPage(currentWorkspace.id, pageId);
+      jumpToPage(currentWorkspace.id, pageId).catch(err => {
+        console.error(err);
+      });
     }
   }
   //#endregion
@@ -353,7 +357,9 @@ export const WorkspaceLayoutInner: FC<PropsWithChildren> = ({ children }) => {
         }
       );
       setCurrentPageId(currentPageId);
-      void jumpToPage(currentWorkspace.id, page.id);
+      jumpToPage(currentWorkspace.id, page.id).catch(err => {
+        console.error(err);
+      });
     }
   }, [
     currentPageId,

apps/web/src/pages/index.tsx

@@ -39,21 +39,31 @@ const IndexPageInner = () => {
         nonTrashPages.at(0)?.id;
       if (pageId) {
         logger.debug('Found target workspace. Jump to page', pageId);
-        void jumpToPage(targetWorkspace.id, pageId, RouteLogic.REPLACE);
+        jumpToPage(targetWorkspace.id, pageId, RouteLogic.REPLACE).catch(
+          err => {
+            console.error(err);
+          }
+        );
       } else {
         const clearId = setTimeout(() => {
           dispose.dispose();
           logger.debug('Found target workspace. Jump to all pages');
-          void jumpToSubPath(
+          jumpToSubPath(
             targetWorkspace.id,
             WorkspaceSubPath.ALL,
             RouteLogic.REPLACE
-          );
+          ).catch(err => {
+            console.error(err);
+          });
         }, 1000);
         const dispose =
           targetWorkspace.blockSuiteWorkspace.slots.pageAdded.once(pageId => {
             clearTimeout(clearId);
-            void jumpToPage(targetWorkspace.id, pageId, RouteLogic.REPLACE);
+            jumpToPage(targetWorkspace.id, pageId, RouteLogic.REPLACE).catch(
+              err => {
+                console.error(err);
+              }
+            );
           });
         return () => {
           clearTimeout(clearId);

apps/web/src/pages/workspace/[workspaceId]/setting.tsx

@@ -11,7 +11,7 @@ import { atomWithStorage } from 'jotai/utils';
 import Head from 'next/head';
 import type { NextRouter } from 'next/router';
 import { useRouter } from 'next/router';
-import React, { useCallback, useEffect } from 'react';
+import React, { useCallback } from 'react';
 
 import { getUIAdapter } from '../../../adapters/workspace';
 import { PageLoading } from '../../../components/pure/loading';
@@ -30,7 +30,7 @@ function useTabRouterSync(
   router: NextRouter,
   currentTab: SettingPanel,
   setCurrentTab: (tab: SettingPanel) => void
-) {
+): void {
   if (!router.isReady) {
     return;
   }
@@ -43,33 +43,36 @@ function useTabRouterSync(
     settingPanelValues.indexOf(queryCurrentTab as SettingPanel) === -1
   ) {
     setCurrentTab(settingPanel.General);
-    void router.replace({
-      pathname: router.pathname,
-      query: {
-        ...router.query,
-        currentTab: settingPanel.General,
-      },
-    });
-    return;
+    router
+      .replace({
+        pathname: router.pathname,
+        query: {
+          ...router.query,
+          currentTab: settingPanel.General,
+        },
+      })
+      .catch(console.error);
   } else if (settingPanelValues.indexOf(currentTab as SettingPanel) === -1) {
     setCurrentTab(settingPanel.General);
-    void router.replace({
-      pathname: router.pathname,
-      query: {
-        ...router.query,
-        currentTab: settingPanel.General,
-      },
-    });
-    return;
+    router
+      .replace({
+        pathname: router.pathname,
+        query: {
+          ...router.query,
+          currentTab: settingPanel.General,
+        },
+      })
+      .catch(console.error);
   } else if (queryCurrentTab !== currentTab) {
-    void router.replace({
-      pathname: router.pathname,
-      query: {
-        ...router.query,
-        currentTab: currentTab,
-      },
-    });
-    return;
+    router
+      .replace({
+        pathname: router.pathname,
+        query: {
+          ...router.query,
+          currentTab: currentTab,
+        },
+      })
+      .catch(console.error);
   }
 }
 
@@ -78,20 +81,24 @@ const SettingPage: NextPageWithLayout = () => {
   const [currentWorkspace] = useCurrentWorkspace();
   const t = useAFFiNEI18N();
   const [currentTab, setCurrentTab] = useAtom(settingPanelAtom);
-  useEffect(() => {});
   const onChangeTab = useCallback(
     (tab: SettingPanel) => {
       setCurrentTab(tab as SettingPanel);
-      void router.push({
-        pathname: router.pathname,
-        query: {
-          ...router.query,
-          currentTab: tab,
-        },
-      });
+      router
+        .push({
+          pathname: router.pathname,
+          query: {
+            ...router.query,
+            currentTab: tab,
+          },
+        })
+        .catch(err => {
+          console.error(err);
+        });
     },
     [router, setCurrentTab]
   );
+
   useTabRouterSync(router, currentTab, setCurrentTab);
 
   const helper = useAppHelper();