From 13625848804d45a1b53f111d4a4362bfb7f07f3d Mon Sep 17 00:00:00 2001
From: Himself65 <himself65@outlook.com>
Date: Tue, 7 Mar 2023 14:21:59 -0600
Subject: [PATCH] fix: add key 'Move to Trash' (#1391)

---
 .../block-suite-page-list/page-list/OperationCell.tsx          | 3 ++-
 packages/i18n/src/resources/en.json                            | 1 +
 tests/local-first-delete-page.spec.ts                          | 2 +-
 tests/local-first-restore-page.spec.ts                         | 2 +-
 tests/local-first-show-delete-modal.spec.ts                    | 2 +-
 tests/local-first-trash-page.spec.ts                           | 2 +-
 6 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/apps/web/src/components/blocksuite/block-suite-page-list/page-list/OperationCell.tsx b/apps/web/src/components/blocksuite/block-suite-page-list/page-list/OperationCell.tsx
index 353e1616c0..d391fca815 100644
--- a/apps/web/src/components/blocksuite/block-suite-page-list/page-list/OperationCell.tsx
+++ b/apps/web/src/components/blocksuite/block-suite-page-list/page-list/OperationCell.tsx
@@ -57,12 +57,13 @@ export const OperationCell: React.FC<OperationCellProps> = ({
         {t('Open in new tab')}
       </MenuItem>
       <MenuItem
+        data-testid="move-to-trash"
         onClick={() => {
           setOpen(true);
         }}
         icon={<DeleteTemporarilyIcon />}
       >
-        {t('Delete')}
+        {t('Move to Trash')}
       </MenuItem>
     </>
   );
diff --git a/packages/i18n/src/resources/en.json b/packages/i18n/src/resources/en.json
index f362285c7f..14c62d2102 100644
--- a/packages/i18n/src/resources/en.json
+++ b/packages/i18n/src/resources/en.json
@@ -43,6 +43,7 @@
   "Delete permanently?": "Delete permanently?",
   "will be moved to Trash": "{{title}} will be moved to Trash",
   "Favorite": "Favorite",
+  "Move to Trash": "Move to Trash",
   "Moved to Trash": "Moved to Trash",
   "Permanently deleted": "Permanently deleted",
   "restored": "{{title}} restored",
diff --git a/tests/local-first-delete-page.spec.ts b/tests/local-first-delete-page.spec.ts
index aa7eda2283..c6c8cdb4a9 100644
--- a/tests/local-first-delete-page.spec.ts
+++ b/tests/local-first-delete-page.spec.ts
@@ -25,7 +25,7 @@ test.describe('Local first delete page', () => {
       .getByRole('button')
       .first()
       .click();
-    const deleteBtn = page.getByRole('button', { name: 'Delete' });
+    const deleteBtn = page.getByTestId('move-to-trash');
     await deleteBtn.click();
     const confirmTip = page.getByText('Delete page?');
     expect(confirmTip).not.toBeUndefined();
diff --git a/tests/local-first-restore-page.spec.ts b/tests/local-first-restore-page.spec.ts
index b067cff5d6..a8b2868e89 100644
--- a/tests/local-first-restore-page.spec.ts
+++ b/tests/local-first-restore-page.spec.ts
@@ -25,7 +25,7 @@ test.describe('Local first delete page', () => {
       .getByRole('button')
       .first()
       .click();
-    const deleteBtn = page.getByRole('button', { name: 'Delete' });
+    const deleteBtn = page.getByTestId('move-to-trash');
     await deleteBtn.click();
     const confirmTip = page.getByText('Delete page?');
     expect(confirmTip).not.toBeUndefined();
diff --git a/tests/local-first-show-delete-modal.spec.ts b/tests/local-first-show-delete-modal.spec.ts
index 1cec19f172..dac4f46dbb 100644
--- a/tests/local-first-show-delete-modal.spec.ts
+++ b/tests/local-first-show-delete-modal.spec.ts
@@ -46,7 +46,7 @@ test.describe('Local first delete page', () => {
       .getByRole('button')
       .first()
       .click();
-    const deleteBtn = page.getByRole('button', { name: 'Delete' });
+    const deleteBtn = page.getByTestId('move-to-trash');
     await deleteBtn.click();
     const confirmTip = page.getByText('Delete page?');
     expect(confirmTip).not.toBeUndefined();
diff --git a/tests/local-first-trash-page.spec.ts b/tests/local-first-trash-page.spec.ts
index 286ad29995..54a3245527 100644
--- a/tests/local-first-trash-page.spec.ts
+++ b/tests/local-first-trash-page.spec.ts
@@ -24,7 +24,7 @@ test.describe('Local first trash page', () => {
       .getByRole('button')
       .first()
       .click();
-    const deleteBtn = page.getByRole('button', { name: 'Delete' });
+    const deleteBtn = page.getByTestId('move-to-trash');
     await deleteBtn.click();
     const confirmTip = page.getByText('Delete page?');
     expect(confirmTip).not.toBeUndefined();