Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-12 04:18:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add prefer-dom-node-dataset rule (#5107)

Browse Source
This commit is contained in:
LongYinan
2023-11-29 04:43:35 +00:00
parent 923844f302
commit 123f091e5b
9 changed files with 13 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/frontend/core/src/components/affine/setting-modal/general-setting/plans/index.tsx
View File

@@ -84,8 +84,7 @@ const Settings = () => {
scrollWrapper.current.getBoundingClientRect().left -
parseInt(wrapperComputedStyle.paddingLeft)
: 0;
const appeared =
scrollWrapper.current.getAttribute('data-appeared') === 'true';
const appeared = scrollWrapper.current.dataset.appeared === 'true';
const animationFrameId = requestAnimationFrame(() => {
scrollWrapper.current?.scrollTo({
behavior: appeared ? 'smooth' : 'instant',

2
packages/plugins/image-preview/src/component/index.jotai.ts
View File

@@ -9,7 +9,7 @@ previewBlockIdAtom.onMount = set => {
if (target?.tagName === 'IMG') {
const imageBlock = target.closest('affine-image');
if (imageBlock) {
const blockId = imageBlock.getAttribute('data-block-id');
const blockId = imageBlock.dataset.blockId;
if (!blockId) return;
set(blockId);
}