refactor(electron): server side plugin (#3360)

apps/electron/src/main/plugin.ts

@@ -1,12 +1,8 @@
 import { join, resolve } from 'node:path';
-import { Worker } from 'node:worker_threads';
 
 import { logger } from '@affine/electron/main/logger';
-import { AsyncCall } from 'async-call-rpc';
 import { ipcMain } from 'electron';
 
-import { MessageEventChannel } from './utils';
-
 declare global {
   // fixme(himself65):
   //  remove this when bookmark block plugin is migrated to plugin-infra
@@ -15,56 +11,25 @@ declare global {
 }
 
 export function registerPlugin() {
-  const pluginWorkerPath = join(__dirname, './workers/plugin.worker.js');
-  const asyncCall = AsyncCall<
-    Record<string, (...args: any) => PromiseLike<any>>
-  >(
-    {
-      log: (...args: any[]) => {
-        logger.log('Plugin Worker', ...args);
-      },
-    },
-    {
-      channel: new MessageEventChannel(new Worker(pluginWorkerPath)),
-    }
-  );
-  globalThis.asyncCall = asyncCall;
   logger.info('import plugin manager');
-  import('@toeverything/plugin-infra/manager')
-    .then(({ rootStore, affinePluginsAtom }) => {
-      logger.info('import plugin manager');
-      const bookmarkPluginPath = join(
-        process.env.PLUGIN_DIR ?? resolve(__dirname, './plugins'),
-        './bookmark-block/index.mjs'
-      );
-      logger.info('bookmark plugin path:', bookmarkPluginPath);
-      import('file://' + bookmarkPluginPath);
-      let dispose: () => void = () => {
-        // noop
-      };
-      rootStore.sub(affinePluginsAtom, () => {
-        dispose();
-        const plugins = rootStore.get(affinePluginsAtom);
-        Object.values(plugins).forEach(plugin => {
-          logger.info('register plugin', plugin.definition.id);
-          plugin.definition.commands.forEach(command => {
-            logger.info('register plugin command', command);
-            ipcMain.handle(command, (event, ...args) =>
-              asyncCall[command](...args)
-            );
-          });
-        });
-        dispose = () => {
-          Object.values(plugins).forEach(plugin => {
-            plugin.definition.commands.forEach(command => {
-              logger.info('unregister plugin command', command);
-              ipcMain.removeHandler(command);
-            });
-          });
-        };
-      });
-    })
-    .catch(error => {
-      logger.error('import plugin manager error', error);
-    });
+  globalThis.asyncCall = {};
+  const bookmarkPluginPath = join(
+    process.env.PLUGIN_DIR ?? resolve(__dirname, './plugins'),
+    './bookmark/index.js'
+  );
+  logger.info('bookmark plugin path:', bookmarkPluginPath);
+  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  const { entry } = require(bookmarkPluginPath);
+
+  entry({
+    registerCommand: (command: string, handler: (...args: any[]) => any) => {
+      logger.info('register plugin command', command);
+      ipcMain.handle(command, (event, ...args) => handler(...args));
+      globalThis.asyncCall[command] = handler;
+    },
+    registerCommands: (command: string) => {
+      ipcMain.removeHandler(command);
+      delete globalThis.asyncCall[command];
+    },
+  });
 }

apps/electron/src/main/workers/plugin.worker.ts

@@ -1,69 +0,0 @@
-import { join, resolve } from 'node:path';
-import { parentPort } from 'node:worker_threads';
-
-import { AsyncCall } from 'async-call-rpc';
-
-import { MessageEventChannel } from '../utils';
-
-const commandProxy: Record<string, (...args: any[]) => Promise<any>> = {};
-
-if (!parentPort) {
-  throw new Error('parentPort is undefined');
-}
-
-const mainThread = AsyncCall<{
-  log: (...args: any[]) => Promise<void>;
-}>(commandProxy, {
-  channel: new MessageEventChannel(parentPort),
-});
-
-globalThis.console.log = mainThread.log;
-globalThis.console.error = mainThread.log;
-globalThis.console.info = mainThread.log;
-globalThis.console.debug = mainThread.log;
-globalThis.console.warn = mainThread.log;
-
-console.log('import plugin infra');
-
-import('@toeverything/plugin-infra/manager')
-  .then(({ rootStore, affinePluginsAtom }) => {
-    const bookmarkPluginPath = join(
-      process.env.PLUGIN_DIR ?? resolve(__dirname, '../plugins'),
-      './bookmark-block/index.mjs'
-    );
-
-    console.log('import bookmark plugin', bookmarkPluginPath);
-
-    import('file://' + bookmarkPluginPath).catch(console.log);
-    rootStore.sub(affinePluginsAtom, () => {
-      const plugins = rootStore.get(affinePluginsAtom);
-      Object.values(plugins).forEach(plugin => {
-        console.log('handle plugin', plugin.definition.id);
-        if (plugin.serverAdapter) {
-          try {
-            plugin.serverAdapter({
-              registerCommand: (command, fn) => {
-                console.log('register command', command);
-                commandProxy[command] = fn;
-              },
-              unregisterCommand: command => {
-                console.log('unregister command', command);
-                delete commandProxy[command];
-              },
-            });
-          } catch (e) {
-            console.log(
-              'error when handle plugin',
-              plugin.definition.id,
-              `${e}`
-            );
-          }
-        } else {
-          console.log('no server adapter, skipping.');
-        }
-      });
-    });
-  })
-  .catch(err => {
-    console.error(err);
-  });