mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-02-14 21:27:20 +00:00
refactor(editor): add a layer of ui-logic to enhance type safety (#12511)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced modular UI logic layers for Kanban and Table views, enhancing maintainability and scalability. - Added new CSS-in-JS style modules for database blocks and table views, improving visual consistency. - Expanded telemetry event tracking for database views, properties, filters, and groups. - Added utility functions for lazy initialization and cached computed values. - **Refactor** - Unified logic and state management across Kanban and Table views by replacing direct component dependencies with logic-centric architecture. - Updated components and widgets to use the new logic-based approach for state, selection, and event handling. - Replaced inline styles with CSS classes; updated class names to align with new component structure. - Centralized state access through UI logic instances, eliminating direct DOM queries and simplifying dependencies. - Consolidated Kanban and Table view presets effects for streamlined initialization. - Replaced Lit reactive state with Preact signals in multiple components for improved reactivity. - Split monolithic components into separate logic and UI classes for clearer separation of concerns. - Removed obsolete components and consolidated exports for cleaner API surface. - **Bug Fixes** - Enhanced selection and interaction reliability in database cells and views. - Fixed scrolling issues on mobile table views for improved compatibility. - **Chores** - Updated end-to-end test selectors to reflect new component names and structure. - Removed deprecated utilities and cleaned up unused imports. - **Documentation** - Improved type definitions and public API exports for better developer experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
@@ -993,18 +993,6 @@ export const getCenterPositionByLocator: (
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* @deprecated Use `page.locator(selector).boundingBox()` instead
|
||||
*/
|
||||
export const getBoundingClientRect: (
|
||||
page: Page,
|
||||
selector: string
|
||||
) => Promise<DOMRect> = async (page: Page, selector: string) => {
|
||||
return page.evaluate((selector: string) => {
|
||||
return document.querySelector(selector)?.getBoundingClientRect() as DOMRect;
|
||||
}, selector);
|
||||
};
|
||||
|
||||
export async function getBoundingBox(locator: Locator) {
|
||||
const box = await locator.boundingBox();
|
||||
if (!box) throw new Error('Missing column box');
|
||||
|
||||
Reference in New Issue
Block a user