mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-08-28 12:19:27 +08:00
refactor(editor): add a layer of ui-logic to enhance type safety (#12511)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced modular UI logic layers for Kanban and Table views, enhancing maintainability and scalability. - Added new CSS-in-JS style modules for database blocks and table views, improving visual consistency. - Expanded telemetry event tracking for database views, properties, filters, and groups. - Added utility functions for lazy initialization and cached computed values. - **Refactor** - Unified logic and state management across Kanban and Table views by replacing direct component dependencies with logic-centric architecture. - Updated components and widgets to use the new logic-based approach for state, selection, and event handling. - Replaced inline styles with CSS classes; updated class names to align with new component structure. - Centralized state access through UI logic instances, eliminating direct DOM queries and simplifying dependencies. - Consolidated Kanban and Table view presets effects for streamlined initialization. - Replaced Lit reactive state with Preact signals in multiple components for improved reactivity. - Split monolithic components into separate logic and UI classes for clearer separation of concerns. - Removed obsolete components and consolidated exports for cleaner API surface. - **Bug Fixes** - Enhanced selection and interaction reliability in database cells and views. - Fixed scrolling issues on mobile table views for improved compatibility. - **Chores** - Updated end-to-end test selectors to reflect new component names and structure. - Removed deprecated utilities and cleaned up unused imports. - **Documentation** - Improved type definitions and public API exports for better developer experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
@@ -264,7 +264,7 @@ export class DataViewHeaderViews extends WidgetBase {
|
||||
<div
|
||||
class="${classList}"
|
||||
style="margin-right: 4px;"
|
||||
@click="${(event: MouseEvent) => this._clickView(event, id)}"
|
||||
@click="${(event: MouseEvent) => this.clickView(event, id)}"
|
||||
>
|
||||
<uni-lit class="icon" .uni="${this.getRenderer(id)?.icon}"></uni-lit>
|
||||
<div class="name">${view?.name}</div>
|
||||
@@ -281,7 +281,7 @@ export class DataViewHeaderViews extends WidgetBase {
|
||||
return this.dataSource.viewMetaGetById(viewId)?.renderer;
|
||||
}
|
||||
|
||||
_clickView(event: MouseEvent, id: string) {
|
||||
private clickView(event: MouseEvent, id: string) {
|
||||
if (this.viewManager.currentViewId$.value !== id) {
|
||||
this.viewManager.setCurrentView(id);
|
||||
this.onChangeView?.(id);
|
||||
|
||||
Reference in New Issue
Block a user