Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-27 10:52:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: remove old setting page by default (#2980)

Browse Source
This commit is contained in:
Alex Yang
2023-07-03 18:59:23 +08:00
parent f16f02b6b0
commit 0e342999fd
3 changed files with 14 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/web/preset.config.mjs
View File

@@ -28,7 +28,7 @@ const buildPreset = {
enableLegacyCloud: false, enableLegacyCloud: false,
changelogUrl: 'https://affine.pro/blog/whats-new-affine-0630', changelogUrl: 'https://affine.pro/blog/whats-new-affine-0630',
enablePreloading: true, enablePreloading: true,
enableNewSettingModal: false, enableNewSettingModal: true,
enableNewSettingUnstableApi: false, enableNewSettingUnstableApi: false,
enableSQLiteProvider: false, enableSQLiteProvider: false,
enableNotificationCenter: false, enableNotificationCenter: false,

30
apps/web/src/components/root-app-sidebar/index.tsx
View File

@@ -175,30 +175,20 @@ export const RootAppSidebar = ({
> >
<span data-testid="all-pages">{t['All pages']()}</span> <span data-testid="all-pages">{t['All pages']()}</span>
</RouteMenuLinkItem> </RouteMenuLinkItem>
<RouteMenuLinkItem {!runtimeConfig.enableNewSettingModal && (
data-testid="slider-bar-workspace-setting-button" <RouteMenuLinkItem
icon={<SettingsIcon />} data-testid="slider-bar-workspace-setting-button"
currentPath={currentPath} icon={<SettingsIcon />}
path={currentWorkspaceId && paths.setting(currentWorkspaceId)} currentPath={currentPath}
> path={currentWorkspaceId && paths.setting(currentWorkspaceId)}
<span data-testid="settings">{t['Settings']()}</span> >
</RouteMenuLinkItem> <span data-testid="settings">{t['Settings']()}</span>
</RouteMenuLinkItem>
)}
{runtimeConfig.enableNewSettingModal ? ( {runtimeConfig.enableNewSettingModal ? (
<MenuItem icon={<SettingsIcon />} onClick={onOpenSettingModal}> <MenuItem icon={<SettingsIcon />} onClick={onOpenSettingModal}>
<span data-testid="settings-modal-trigger"> <span data-testid="settings-modal-trigger">
{t['Settings']()} {t['Settings']()}
<i
style={{
background: 'var(--affine-palette-line-blue)',
borderRadius: '2px',
fontSize: '8px',
padding: '0 5px',
color: 'var(--affine-white)',
marginLeft: '15px',
}}
>
NEW
</i>
</span> </span>
</MenuItem> </MenuItem>
) : null} ) : null}

4
tests/parallels/local-first-avatar.spec.ts
View File

@@ -17,10 +17,12 @@ test('should create a page with a local first avatar', async ({ page }) => {
await page.getByTestId('create-workspace-create-button').click(); await page.getByTestId('create-workspace-create-button').click();
await page.getByTestId('workspace-name').click(); await page.getByTestId('workspace-name').click();
await page.getByTestId('workspace-card').nth(1).click(); await page.getByTestId('workspace-card').nth(1).click();
await page.getByTestId('slider-bar-workspace-setting-button').click(); await page.getByTestId('settings-modal-trigger').click();
await page.getByText('current').click();
await page await page
.getByTestId('upload-avatar') .getByTestId('upload-avatar')
.setInputFiles('./tests/fixtures/smile.png'); .setInputFiles('./tests/fixtures/smile.png');
await page.mouse.click(0, 0);
await page.getByTestId('workspace-name').click(); await page.getByTestId('workspace-name').click();
await page.getByTestId('workspace-card').nth(0).click(); await page.getByTestId('workspace-card').nth(0).click();
await page.waitForTimeout(1000); await page.waitForTimeout(1000);