From 0ca8a23dd8e422563f1b20cd0d6db88054648537 Mon Sep 17 00:00:00 2001
From: regischen <58546692+regischen@users.noreply.github.com>
Date: Tue, 16 Apr 2024 08:11:37 +0000
Subject: [PATCH] fix: move help land position (#6571)

Before:
<img width="1614" alt="image" src="https://github.com/toeverything/AFFiNE/assets/58546692/24d4c550-4070-48a5-a851-40d6f26ea120">

After:
<img width="1106" alt="image" src="https://github.com/toeverything/AFFiNE/assets/58546692/88e1b7ea-8a69-45a2-9beb-780dfd1bd996">
<img width="949" alt="image" src="https://github.com/toeverything/AFFiNE/assets/58546692/8fd328c5-e8e8-402a-b18e-436056d2374f">

Cause the icon will be on top of chat input.
---
 .../workbench/view/split-view/split-view.css.ts |  1 +
 .../workbench/view/split-view/split-view.tsx    |  2 ++
 .../modules/workbench/view/workbench-root.tsx   | 17 ++++++-----------
 3 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/packages/frontend/core/src/modules/workbench/view/split-view/split-view.css.ts b/packages/frontend/core/src/modules/workbench/view/split-view/split-view.css.ts
index 873740c5bb..f9c6c889e5 100644
--- a/packages/frontend/core/src/modules/workbench/view/split-view/split-view.css.ts
+++ b/packages/frontend/core/src/modules/workbench/view/split-view/split-view.css.ts
@@ -11,6 +11,7 @@ export const splitViewRoot = style({
   },
   display: 'flex',
   flexDirection: 'row',
+  position: 'relative',
   borderRadius,
   gap,
 
diff --git a/packages/frontend/core/src/modules/workbench/view/split-view/split-view.tsx b/packages/frontend/core/src/modules/workbench/view/split-view/split-view.tsx
index dd1c2deec0..f9a6cba126 100644
--- a/packages/frontend/core/src/modules/workbench/view/split-view/split-view.tsx
+++ b/packages/frontend/core/src/modules/workbench/view/split-view/split-view.tsx
@@ -1,3 +1,4 @@
+import { HubIsland } from '@affine/core/components/affine/hub-island';
 import { useAppSettingHelper } from '@affine/core/hooks/affine/use-app-setting-helper';
 import type { DragEndEvent } from '@dnd-kit/core';
 import {
@@ -108,6 +109,7 @@ export const SplitView = ({
       data-client-border={appSettings.clientBorder}
       {...attrs}
     >
+      <HubIsland />
       <DndContext
         sensors={sensors}
         collisionDetection={closestCenter}
diff --git a/packages/frontend/core/src/modules/workbench/view/workbench-root.tsx b/packages/frontend/core/src/modules/workbench/view/workbench-root.tsx
index 66ae57fa46..bebf038274 100644
--- a/packages/frontend/core/src/modules/workbench/view/workbench-root.tsx
+++ b/packages/frontend/core/src/modules/workbench/view/workbench-root.tsx
@@ -1,4 +1,3 @@
-import { HubIsland } from '@affine/core/components/affine/hub-island';
 import { useLiveData, useService } from '@toeverything/infra';
 import { useCallback, useEffect, useRef } from 'react';
 import { useLocation } from 'react-router-dom';
@@ -44,16 +43,12 @@ export const WorkbenchRoot = () => {
   }, [basename, workbench.basename$]);
 
   return (
-    <>
-      <HubIsland />
-
-      <SplitView
-        className={styles.workbenchRootContainer}
-        views={views}
-        renderer={panelRenderer}
-        onMove={onMove}
-      />
-    </>
+    <SplitView
+      className={styles.workbenchRootContainer}
+      views={views}
+      renderer={panelRenderer}
+      onMove={onMove}
+    />
   );
 };