From 08a30edb2d0678249c5df7b196b5a31117b43806 Mon Sep 17 00:00:00 2001 From: keke <60368137+kekekuli@users.noreply.github.com> Date: Wed, 24 Dec 2025 02:45:39 +0800 Subject: [PATCH] chore: correct the wrong file path in building doc (#14145) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When I read the [building-desktop-client-app.md](https://github.com/toeverything/AFFiNE/blob/canary/docs/building-desktop-client-app.md) to build Artifacts locally, I find there have some legacy path due to some project structure updates. So this is a litte fix to correct the unmatched path in the doc. ## Summary by CodeRabbit * **Documentation** * Updated desktop client app building documentation to reflect changes in the project structure and configuration setup. ✏️ Tip: You can customize this high-level summary in your review settings. --- docs/building-desktop-client-app.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/building-desktop-client-app.md b/docs/building-desktop-client-app.md index 7a306986df..8b47f66c47 100644 --- a/docs/building-desktop-client-app.md +++ b/docs/building-desktop-client-app.md @@ -18,7 +18,7 @@ Building the desktop client app for the moment is a bit more complicated than bu 1. `packages/frontend/core`: the web app 2. `packages/frontend/native`: the native modules written in Rust (mostly the sqlite bindings) -3. `packages/frontend/electron`: the Electron app (containing main & helper process, and the electron entry point in `packages/frontend/electron-renderer`) +3. `packages/frontend/apps/electron`: the Electron app (containing main & helper process, and the electron entry point in `packages/frontend/apps/electron-renderer`) #3 is dependent on #1 and #2, and relies on electron-forge to make the final app & installer. To get a deep understanding of how the desktop client app is built, you may want to read the workflow file in [release-desktop.yml](/.github/workflows/release-desktop.yml). @@ -91,7 +91,7 @@ yarn install #### Mac & Linux -Note: you need to comment out `osxSign` and `osxNotarize` in `forge.config.js` to skip signing and notarizing the app. +Note: you need to comment out `osxSign` and `osxNotarize` in `forge.config.mjs` to skip signing and notarizing the app. ```shell BUILD_TYPE=canary SKIP_WEB_BUILD=1 HOIST_NODE_MODULES=1 yarn affine @affine/electron make