From 0220ba45729fe6592b7cc33db61e1c13069dd860 Mon Sep 17 00:00:00 2001 From: Saul-Mirone Date: Thu, 26 Dec 2024 03:37:10 +0000 Subject: [PATCH] fix: should bring children to new doc created (#9316) Closes: [BS-2186](https://linear.app/affine-design/issue/BS-2186/created-linked-doc-%E6%97%B6%EF%BC%8C%E4%BC%9A%E6%B8%85%E9%99%A4list%E7%9A%84-children) --- blocksuite/affine/block-note/src/quick-action.ts | 2 +- blocksuite/blocks/src/root-block/widgets/format-bar/config.ts | 2 +- blocksuite/tests-legacy/format-bar.spec.ts | 3 +++ ...create-linked-doc-from-block-selection-with-format-bar.json | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/blocksuite/affine/block-note/src/quick-action.ts b/blocksuite/affine/block-note/src/quick-action.ts index 68e129af16..a78adadd65 100644 --- a/blocksuite/affine/block-note/src/quick-action.ts +++ b/blocksuite/affine/block-note/src/quick-action.ts @@ -32,7 +32,7 @@ export const quickActionConfig: QuickActionConfig[] = [ .chain() .getSelectedModels({ types: ['block'], - mode: 'highest', + mode: 'flat', }) .draftSelectedModels() .run(); diff --git a/blocksuite/blocks/src/root-block/widgets/format-bar/config.ts b/blocksuite/blocks/src/root-block/widgets/format-bar/config.ts index 904a2f90bc..01feb1e34f 100644 --- a/blocksuite/blocks/src/root-block/widgets/format-bar/config.ts +++ b/blocksuite/blocks/src/root-block/widgets/format-bar/config.ts @@ -197,7 +197,7 @@ export function toolbarDefaultConfig(toolbar: AffineFormatBarWidget) { const [_, ctx] = chain .getSelectedModels({ types: ['block', 'text'], - mode: 'highest', + mode: 'flat', }) .draftSelectedModels() .run(); diff --git a/blocksuite/tests-legacy/format-bar.spec.ts b/blocksuite/tests-legacy/format-bar.spec.ts index c9b7dd4fdc..8165f4766b 100644 --- a/blocksuite/tests-legacy/format-bar.spec.ts +++ b/blocksuite/tests-legacy/format-bar.spec.ts @@ -965,6 +965,9 @@ test('create linked doc from block selection with format bar', async ({ expect(await getPageSnapshot(page, true)).toMatchSnapshot( `${testInfo.title}.json` ); + + const paragraph = page.locator('affine-paragraph'); + await expect(paragraph).toHaveCount(3); }); test.describe('more menu button', () => { diff --git a/blocksuite/tests-legacy/snapshots/format-bar.spec.ts/create-linked-doc-from-block-selection-with-format-bar.json b/blocksuite/tests-legacy/snapshots/format-bar.spec.ts/create-linked-doc-from-block-selection-with-format-bar.json index f1f55038c6..fc2043b921 100644 --- a/blocksuite/tests-legacy/snapshots/format-bar.spec.ts/create-linked-doc-from-block-selection-with-format-bar.json +++ b/blocksuite/tests-legacy/snapshots/format-bar.spec.ts/create-linked-doc-from-block-selection-with-format-bar.json @@ -34,7 +34,7 @@ "children": [ { "type": "block", - "id": "11", + "id": "12", "flavour": "affine:embed-linked-doc", "version": 1, "props": {